From patchwork Wed Nov 7 15:09:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Meng Koon Lim X-Patchwork-Id: 10672535 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E20DE175A for ; Wed, 7 Nov 2018 15:09:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D302A2C3F2 for ; Wed, 7 Nov 2018 15:09:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C720C2C3F5; Wed, 7 Nov 2018 15:09:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from bastion.fedoraproject.org (bastion01.fedoraproject.org [209.132.181.2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5755F2C3F2 for ; Wed, 7 Nov 2018 15:09:43 +0000 (UTC) Received: from mailman01.phx2.fedoraproject.org (mailman01.phx2.fedoraproject.org [10.5.126.36]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id 8F14F63EF64C; Wed, 7 Nov 2018 15:09:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org 8F14F63EF64C Received: from mailman01.phx2.fedoraproject.org (localhost [IPv6:::1]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id 85F4223FACD4F; Wed, 7 Nov 2018 15:09:42 +0000 (UTC) Received: by mailman01.phx2.fedoraproject.org (Postfix, from userid 991) id 2613023FACD4F; Wed, 7 Nov 2018 15:09:39 +0000 (UTC) Received: from smtp-mm-osuosl01.fedoraproject.org (smtp-mm-osuosl01.vpn.fedoraproject.org [192.168.1.23]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id D72C023FACD4E for ; Wed, 7 Nov 2018 15:09:38 +0000 (UTC) Received: from 8c8590b355e5.ant.amazon.com (unknown [118.200.90.214]) by smtp-mm-osuosl01.fedoraproject.org (Postfix) with ESMTP id 7485598057 for ; Wed, 7 Nov 2018 15:09:38 +0000 (UTC) Received: by 8c8590b355e5.ant.amazon.com (Postfix, from userid 587976549) id A65C013FF784; Wed, 7 Nov 2018 23:09:20 +0800 (+08) From: Meng Koon Lim To: libteam@lists.fedorahosted.org Subject: [patch libteam] teamd: lacp: send LACPDU when port state transitions from DEFAULT to CURRENT Date: Wed, 7 Nov 2018 23:09:17 +0800 Message-Id: <20181107150917.80542-1-mengkoon@live.com> X-Mailer: git-send-email 2.14.3 (Apple Git-98) Message-ID-Hash: BAEX5UNMDBHB3L44N7RAZLYP57HQBQOY X-Message-ID-Hash: BAEX5UNMDBHB3L44N7RAZLYP57HQBQOY X-MailFrom: menglim@8c8590b355e5.ant.amazon.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Meng Koon Lim , jiri@resnulli.us X-Mailman-Version: 3.1.1 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Currently, when local port state become DEFAULTED, its Partner_State field is set to 0x00 Bit 1 in Actor_State and Partner_State field is for LACP_Timeout. When set, it means LACP fast is used. If teamd_runner_lacp receives an LACPDU with Actor_State field bit 1 set, it transitions local port to CURRENT, and transmits LACPDU If teamd_runner_lacp receives an LACPDU without Actor_State field bit 1 set, it transitions local port to CURRENT, but does not transmit LACPDU The second scenario results in teamd starting data transmission when partner port remains in either Defaulted or Expired state, causing packets to be dropped by partner Fix this by setting Partner_State field to 0x02 on the local port when local port state transitions to DEFAULTED Signed-off-by: Meng Koon Lim --- teamd/teamd_runner_lacp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 7b8f0a7..555aa06 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -965,7 +965,12 @@ static int lacp_port_set_state(struct lacp_port *lacp_port, case PORT_STATE_DEFAULTED: teamd_loop_callback_disable(lacp_port->ctx, LACP_TIMEOUT_CB_NAME, lacp_port); - /* fall through */ + memset(&lacp_port->partner, 0, sizeof(lacp_port->partner)); + lacp_port->partner.state |= INFO_STATE_LACP_TIMEOUT; + err = lacp_port_partner_update(lacp_port); + if (err) + return err; + break; case PORT_STATE_DISABLED: memset(&lacp_port->partner, 0, sizeof(lacp_port->partner)); err = lacp_port_partner_update(lacp_port);