Message ID | 20181107201055.25883-2-josef@toxicpanda.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | xfs: fix panics seen with error injection | expand |
On Wed, Nov 07, 2018 at 03:10:54PM -0500, Josef Bacik wrote: > In order to make error injection triggering easier make > xfs_buf_ioapply_map STATIC so it's noinline and can be kprobe'ed. So per the whole STATIC discussion how about throwing in an explicit noinline instead? Then again if you really are about error injection we should probably have a real tag here. Either explicit error injection like we have in many places in XFS, or a trace point which should give a really nice hook, too.
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index b21ea2ba768d..341bdb55b650 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1327,7 +1327,7 @@ xfs_buf_bio_end_io( bio_put(bio); } -static void +STATIC void xfs_buf_ioapply_map( struct xfs_buf *bp, int map,
In order to make error injection triggering easier make xfs_buf_ioapply_map STATIC so it's noinline and can be kprobe'ed. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)