diff mbox series

[03/15] drm/i915/tv: Fix interlaced ysize calculation

Message ID 20181112170000.27531-4-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Fix TV encoder support | expand

Commit Message

Ville Syrjala Nov. 12, 2018, 4:59 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Fix the calculation of the vertical active period for interlaced
TV modes.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_tv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Imre Deak Jan. 22, 2019, 12:54 p.m. UTC | #1
On Mon, Nov 12, 2018 at 06:59:47PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Fix the calculation of the vertical active period for interlaced
> TV modes.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Matches the spec:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_tv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index 860f306a23ba..219a16d6dcc2 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -1087,7 +1087,7 @@ static void intel_tv_pre_enable(struct intel_encoder *encoder,
>  	if (tv_mode->progressive)
>  		ysize = tv_mode->nbr_end + 1;
>  	else
> -		ysize = 2*tv_mode->nbr_end + 1;
> +		ysize = 2 * (tv_mode->nbr_end + 1);
>  
>  	xpos += conn_state->tv.margins.left;
>  	ypos += conn_state->tv.margins.top;
> -- 
> 2.18.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 860f306a23ba..219a16d6dcc2 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1087,7 +1087,7 @@  static void intel_tv_pre_enable(struct intel_encoder *encoder,
 	if (tv_mode->progressive)
 		ysize = tv_mode->nbr_end + 1;
 	else
-		ysize = 2*tv_mode->nbr_end + 1;
+		ysize = 2 * (tv_mode->nbr_end + 1);
 
 	xpos += conn_state->tv.margins.left;
 	ypos += conn_state->tv.margins.top;