diff mbox series

fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()

Message ID 20181115001214.48210-1-ebiggers@kernel.org (mailing list archive)
State New, archived
Headers show
Series fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo() | expand

Commit Message

Eric Biggers Nov. 15, 2018, 12:12 a.m. UTC 
From: Eric Biggers <ebiggers@google.com>

inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
fs/notify/fdinfo.h, but the declaration isn't included at the point of
the definition.  Include the header to enforce that the definition
matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/notify/fdinfo.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Kara Nov. 15, 2018, 4:35 p.m. UTC | #1 
On Wed 14-11-18 16:12:14, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
> fs/notify/fdinfo.h, but the declaration isn't included at the point of
> the definition.  Include the header to enforce that the definition
> matches the declaration.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Good point. Patch applied. Thanks!

								Honza

> ---
>  fs/notify/fdinfo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> index 348a184bcdda3..1e2bfd26b3521 100644
> --- a/fs/notify/fdinfo.c
> +++ b/fs/notify/fdinfo.c
> @@ -15,6 +15,7 @@
>  #include <linux/exportfs.h>
>  
>  #include "inotify/inotify.h"
> +#include "fdinfo.h"
>  #include "fsnotify.h"
>  
>  #if defined(CONFIG_PROC_FS)
> -- 
> 2.19.1.930.g4563a0d9d0-goog
>
diff mbox series

Patch

diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 348a184bcdda3..1e2bfd26b3521 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -15,6 +15,7 @@ 
 #include <linux/exportfs.h>
 
 #include "inotify/inotify.h"
+#include "fdinfo.h"
 #include "fsnotify.h"
 
 #if defined(CONFIG_PROC_FS)