| Message ID | 1542249898-20406-1-git-send-email-chenhc@lemote.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (w83795) temp4_type has writable permission | expand |
On Thu, Nov 15, 2018 at 10:44:57AM +0800, Huacai Chen wrote: > Signed-off-by: Yao Wang <wangyao@lemote.com> > Signed-off-by: Huacai Chen <chenhc@lemote.com> Sorry, that really lacks context. Please add some details. Guenter > --- > drivers/hwmon/w83795.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c > index 49276bb..1bb80f9 100644 > --- a/drivers/hwmon/w83795.c > +++ b/drivers/hwmon/w83795.c > @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr, > * somewhere else in the code > */ > #define SENSOR_ATTR_TEMP(index) { \ > - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \ > + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \ > show_temp_mode, store_temp_mode, NOT_USED, index - 1), \ > SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \ > NULL, TEMP_READ, index - 1), \ > -- > 2.7.0 >
Both datasheet and the comments of store_temp_mode() tell us that temp1~4 is writable, so fix it. Huacai ------------------ Original ------------------ From: "Guenter Roeck"<linux@roeck-us.net>; Date: Thu, Nov 15, 2018 01:23 PM To: "Huacai Chen"<chenhc@lemote.com>; Cc: "Jean Delvare"<jdelvare@suse.com>; "linux-hwmon"<linux-hwmon@vger.kernel.org>; "Fuxin Zhang"<zhangfx@lemote.com>; "Yao Wang"<wangyao@lemote.com>; Subject: Re: [PATCH] hwmon: (w83795) temp4_type has writable permission On Thu, Nov 15, 2018 at 10:44:57AM +0800, Huacai Chen wrote: > Signed-off-by: Yao Wang <wangyao@lemote.com> > Signed-off-by: Huacai Chen <chenhc@lemote.com> Sorry, that really lacks context. Please add some details. Guenter > --- > drivers/hwmon/w83795.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c > index 49276bb..1bb80f9 100644 > --- a/drivers/hwmon/w83795.c > +++ b/drivers/hwmon/w83795.c > @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr, > * somewhere else in the code > */ > #define SENSOR_ATTR_TEMP(index) { \ > - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \ > + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \ > show_temp_mode, store_temp_mode, NOT_USED, index - 1), \ > SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \ > NULL, TEMP_READ, index - 1), \ > -- > 2.7.0 >
On Thu, Nov 15, 2018 at 10:44:57AM +0800, Huacai Chen wrote: > Signed-off-by: Yao Wang <wangyao@lemote.com> > Signed-off-by: Huacai Chen <chenhc@lemote.com> Applied, after adding separately sent description / rationale. For future submission I would kindly suggest to send patches with complete descriptions. Thanks, Guenter > --- > drivers/hwmon/w83795.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c > index 49276bb..1bb80f9 100644 > --- a/drivers/hwmon/w83795.c > +++ b/drivers/hwmon/w83795.c > @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr, > * somewhere else in the code > */ > #define SENSOR_ATTR_TEMP(index) { \ > - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \ > + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \ > show_temp_mode, store_temp_mode, NOT_USED, index - 1), \ > SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \ > NULL, TEMP_READ, index - 1), \
diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c index 49276bb..1bb80f9 100644 --- a/drivers/hwmon/w83795.c +++ b/drivers/hwmon/w83795.c @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr, * somewhere else in the code */ #define SENSOR_ATTR_TEMP(index) { \ - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \ + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \ show_temp_mode, store_temp_mode, NOT_USED, index - 1), \ SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \ NULL, TEMP_READ, index - 1), \