Message ID | 1542302291-6864-5-git-send-email-jhugo@codeaurora.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Andy Gross |
Headers | show |
Series | Enable SD crd slot on msm8998 MTP | expand |
On Thu, Nov 15, 2018 at 10:18:11AM -0700, Jeffrey Hugo wrote: > The externally accessible SD card slot on the MTP is driven by SDCC2. > Wire it up for use. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++ > arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > index b4276da..a90b427 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > @@ -241,3 +241,16 @@ > }; > }; > }; > + > +&sdhc2 { > + status = "okay"; > + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>; > + > + vmmc-supply = <&vreg_l21a_2p95>; > + vqmmc-supply = <&vreg_l13a_2p95>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; Fix to use tabs instead of spaces. Regards, Andy
On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote: > The externally accessible SD card slot on the MTP is driven by SDCC2. > Wire it up for use. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++ > arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > index b4276da..a90b427 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > @@ -241,3 +241,16 @@ > }; > }; > }; > + > +&sdhc2 { > + status = "okay"; Please fix the indentation of the rest of the properties in this block. > + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>; > + > + vmmc-supply = <&vreg_l21a_2p95>; > + vqmmc-supply = <&vreg_l13a_2p95>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > +}; With that, Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn
On 11/15/2018 12:05 PM, Andy Gross wrote: > On Thu, Nov 15, 2018 at 10:18:11AM -0700, Jeffrey Hugo wrote: >> The externally accessible SD card slot on the MTP is driven by SDCC2. >> Wire it up for use. >> >> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++ >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> index b4276da..a90b427 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> @@ -241,3 +241,16 @@ >> }; >> }; >> }; >> + >> +&sdhc2 { >> + status = "okay"; >> + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>; >> + >> + vmmc-supply = <&vreg_l21a_2p95>; >> + vqmmc-supply = <&vreg_l13a_2p95>; >> + >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; >> + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > > Fix to use tabs instead of spaces. Doh. Nice catch. I see I didn't commit that change in my tree. I'll send out a V2 with this and any other fixes folks comment on.
diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi index b4276da..a90b427 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi @@ -241,3 +241,16 @@ }; }; }; + +&sdhc2 { + status = "okay"; + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>; + + vmmc-supply = <&vreg_l21a_2p95>; + vqmmc-supply = <&vreg_l13a_2p95>; + + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; +}; + diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 94827f4..8e7d788 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -3,6 +3,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/qcom,gcc-msm8998.h> +#include <dt-bindings/gpio/gpio.h> / { interrupt-parent = <&intc>;
The externally accessible SD card slot on the MTP is driven by SDCC2. Wire it up for use. Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + 2 files changed, 14 insertions(+)