Message ID | 1542302291-6864-2-git-send-email-jhugo@codeaurora.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Andy Gross |
Headers | show |
Series | Enable SD crd slot on msm8998 MTP | expand |
On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote: > The root parent clock of most msm8998 clock is the "xo" clock. The DT node > is incorrectly named "xo_board", which prevents Linux from correctly > parsing the clock tree, resulting in most clocks being unparented and > unable to be manipulated. The end result is that we can't turn on clocks > for peripherals like SD, so init usually fails. > > Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support) > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 78227cc..a948d4b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -53,7 +53,7 @@ > }; > > clocks { > - xo_board { > + xo { You could have taken the opportunity and added the label here... > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <19200000>; Regards, Bjorn
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 78227cc..a948d4b 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -53,7 +53,7 @@ }; clocks { - xo_board { + xo { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <19200000>;
The root parent clock of most msm8998 clock is the "xo" clock. The DT node is incorrectly named "xo_board", which prevents Linux from correctly parsing the clock tree, resulting in most clocks being unparented and unable to be manipulated. The end result is that we can't turn on clocks for peripherals like SD, so init usually fails. Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support) Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)