| Message ID | 20181116112526.10552-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [-next] drm/msm: dpu: Fix "WARNING: invalid free of devm_ allocated data" | expand |
On Fri, Nov 16, 2018 at 07:25:26PM +0800, YueHaibing wrote: > 'dpu_enc' is a member of 'drm_enc' > And 'drm_enc' got allocated with devm_kzalloc in dpu_encoder_init. > > This gives this error message: > ./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:459:1-6: > WARNING: invalid free of devm_ allocated data I had partial fix of this in my ill-fated patch from a few weeks ago but this is better. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 82c55ef..99526d9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -455,8 +455,6 @@ static void dpu_encoder_destroy(struct drm_encoder *drm_enc) > > drm_encoder_cleanup(drm_enc); > mutex_destroy(&dpu_enc->enc_lock); > - > - kfree(dpu_enc); > } > > void dpu_encoder_helper_split_config( > -- > 2.7.0 > >
On Fri, Nov 16, 2018 at 07:25:26PM +0800, YueHaibing wrote: > 'dpu_enc' is a member of 'drm_enc' It's the other way around :) > And 'drm_enc' got allocated with devm_kzalloc in dpu_encoder_init. > > This gives this error message: > ./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:459:1-6: > WARNING: invalid free of devm_ allocated data > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Sean Paul <sean@poorly.run> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 82c55ef..99526d9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -455,8 +455,6 @@ static void dpu_encoder_destroy(struct drm_encoder *drm_enc) > > drm_encoder_cleanup(drm_enc); > mutex_destroy(&dpu_enc->enc_lock); > - > - kfree(dpu_enc); > } > > void dpu_encoder_helper_split_config( > -- > 2.7.0 > >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 82c55ef..99526d9 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -455,8 +455,6 @@ static void dpu_encoder_destroy(struct drm_encoder *drm_enc) drm_encoder_cleanup(drm_enc); mutex_destroy(&dpu_enc->enc_lock); - - kfree(dpu_enc); } void dpu_encoder_helper_split_config(
'dpu_enc' is a member of 'drm_enc' And 'drm_enc' got allocated with devm_kzalloc in dpu_encoder_init. This gives this error message: ./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:459:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- 1 file changed, 2 deletions(-)