| Message ID | 1542367879-28880-14-git-send-email-yhchuang@realtek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: mac80211 driver for Realtek 802.11ac wireless network chips | expand |
Hi Yan-Hsuan, On Fri, Nov 16, 2018 at 07:31:19PM +0800, yhchuang@realtek.com wrote: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > --- > MAINTAINERS | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9ad052a..138515b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12546,6 +12546,14 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.g > S: Maintained > F: drivers/net/wireless/realtek/rtlwifi/ > > +REALTEK WIRELESS DRIVER (rtw88) > +M: Yan-Hsuan Chuang <yhchuang@realtek.com> > +L: linux-wireless@vger.kernel.org > +W: http://wireless.kernel.org/ > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git That tree hasn't been updated in years. I expect that's not relevant, so perhaps you should remove it? I think these days, unless you have a large amount of patches that deserves its own tree / pull-request, you're probably just going to be covered by the wireless-drivers / wireless-drivers-next trees: NETWORKING DRIVERS (WIRELESS) M: Kalle Valo <kvalo@codeaurora.org> L: linux-wireless@vger.kernel.org Q: http://patchwork.kernel.org/project/linux-wireless/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git Regards, Brian > +S: Maintained > +F: drivers/net/wireless/realtek/rtw88/ > + > RTL8XXXU WIRELESS DRIVER (rtl8xxxu) > M: Jes Sorensen <Jes.Sorensen@gmail.com> > L: linux-wireless@vger.kernel.org
> -----Original Message----- > From: Brian Norris [mailto:briannorris@chromium.org] > Sent: Wednesday, January 23, 2019 5:35 AM > To: Tony Chuang > Cc: kvalo@codeaurora.org; Larry.Finger@lwfinger.net; > linux-wireless@vger.kernel.org; Pkshih; Andy Huang > Subject: Re: [PATCH v2 13/13] rtw88: add support for Realtek 802.11ac wireless > chips > > Hi Yan-Hsuan, > > On Fri, Nov 16, 2018 at 07:31:19PM +0800, yhchuang@realtek.com wrote: > > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > > --- > > MAINTAINERS | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 9ad052a..138515b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12546,6 +12546,14 @@ T: git > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.g > > S: Maintained > > F: drivers/net/wireless/realtek/rtlwifi/ > > > > +REALTEK WIRELESS DRIVER (rtw88) > > +M: Yan-Hsuan Chuang <yhchuang@realtek.com> > > +L: linux-wireless@vger.kernel.org > > +W: http://wireless.kernel.org/ > > +T: git > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git > > That tree hasn't been updated in years. I expect that's not relevant, so > perhaps you should remove it? I think these days, unless you have a > large amount of patches that deserves its own tree / pull-request, > you're probably just going to be covered by the wireless-drivers / > wireless-drivers-next trees: > > NETWORKING DRIVERS (WIRELESS) > M: Kalle Valo <kvalo@codeaurora.org> > L: linux-wireless@vger.kernel.org > Q: http://patchwork.kernel.org/project/linux-wireless/list/ > T: git > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > T: git > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > > Regards, > Brian > OK, I can change to wireless-drivers tree and send PATCHv3. Thanks. Yan-Hsuan
Hi, On Sun, Jan 27, 2019 at 7:36 PM Tony Chuang <yhchuang@realtek.com> wrote: > > -----Original Message----- > > From: Brian Norris [mailto:briannorris@chromium.org] > > > > On Fri, Nov 16, 2018 at 07:31:19PM +0800, yhchuang@realtek.com wrote: > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 9ad052a..138515b 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -12546,6 +12546,14 @@ T: git > > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.g > > > S: Maintained > > > F: drivers/net/wireless/realtek/rtlwifi/ > > > > > > +REALTEK WIRELESS DRIVER (rtw88) > > > +M: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > +L: linux-wireless@vger.kernel.org > > > +W: http://wireless.kernel.org/ > > > +T: git > > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git > > > > That tree hasn't been updated in years. I expect that's not relevant, so > > perhaps you should remove it? I think these days, unless you have a > > large amount of patches that deserves its own tree / pull-request, > > you're probably just going to be covered by the wireless-drivers / > > wireless-drivers-next trees: > > > > NETWORKING DRIVERS (WIRELESS) > > M: Kalle Valo <kvalo@codeaurora.org> > > L: linux-wireless@vger.kernel.org > > Q: http://patchwork.kernel.org/project/linux-wireless/list/ > > T: git > > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > > T: git > > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > > OK, I can change to wireless-drivers tree and send PATCHv3. I wouldn't list wireless-drivers directly -- you don't need to list any tree at all, and the "NETWORKING DRIVERS (WIRELESS)" entry will cover you anyway. Notice how none of these list their own trees either: MARVELL MWIFIEX WIRELESS DRIVER MARVELL MWL8K WIRELESS DRIVER MEDIATEK MT76 WIRELESS LAN DRIVER ORINOCO DRIVER P54 WIRELESS DRIVER ... It's probably not worth another resend. If Kalle cares, I'm sure he can delete your 'T:' line. Brian
Brian Norris <briannorris@chromium.org> writes: > Hi, > > On Sun, Jan 27, 2019 at 7:36 PM Tony Chuang <yhchuang@realtek.com> wrote: >> > -----Original Message----- >> > From: Brian Norris [mailto:briannorris@chromium.org] >> > >> > On Fri, Nov 16, 2018 at 07:31:19PM +0800, yhchuang@realtek.com wrote: >> > > diff --git a/MAINTAINERS b/MAINTAINERS >> > > index 9ad052a..138515b 100644 >> > > --- a/MAINTAINERS >> > > +++ b/MAINTAINERS >> > > @@ -12546,6 +12546,14 @@ T: git >> > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.g >> > > S: Maintained >> > > F: drivers/net/wireless/realtek/rtlwifi/ >> > > >> > > +REALTEK WIRELESS DRIVER (rtw88) >> > > +M: Yan-Hsuan Chuang <yhchuang@realtek.com> >> > > +L: linux-wireless@vger.kernel.org >> > > +W: http://wireless.kernel.org/ >> > > +T: git >> > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git >> > >> > That tree hasn't been updated in years. I expect that's not relevant, so >> > perhaps you should remove it? I think these days, unless you have a >> > large amount of patches that deserves its own tree / pull-request, >> > you're probably just going to be covered by the wireless-drivers / >> > wireless-drivers-next trees: >> > >> > NETWORKING DRIVERS (WIRELESS) >> > M: Kalle Valo <kvalo@codeaurora.org> >> > L: linux-wireless@vger.kernel.org >> > Q: http://patchwork.kernel.org/project/linux-wireless/list/ >> > T: git >> > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git >> > T: git >> > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git >> >> OK, I can change to wireless-drivers tree and send PATCHv3. > > I wouldn't list wireless-drivers directly -- you don't need to list > any tree at all, and the "NETWORKING DRIVERS (WIRELESS)" entry will > cover you anyway. I agree, no need to duplicate the git tree entry for every driver. The top level "NETWORKING DRIVERS (WIRELESS)" entry should be enough.
diff --git a/MAINTAINERS b/MAINTAINERS index 9ad052a..138515b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12546,6 +12546,14 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.g S: Maintained F: drivers/net/wireless/realtek/rtlwifi/ +REALTEK WIRELESS DRIVER (rtw88) +M: Yan-Hsuan Chuang <yhchuang@realtek.com> +L: linux-wireless@vger.kernel.org +W: http://wireless.kernel.org/ +T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git +S: Maintained +F: drivers/net/wireless/realtek/rtw88/ + RTL8XXXU WIRELESS DRIVER (rtl8xxxu) M: Jes Sorensen <Jes.Sorensen@gmail.com> L: linux-wireless@vger.kernel.org