| Message ID | 20181118173056.4591-1-marek.vasut+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: can: rcar_can: document r8a77990 support | expand |
On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: > Document the support for rcar_can on R8A77990 SoC devices. > Add R8A77990 to the list of SoCs which require the "assigned-clocks" > and "assigned-clock-rates" properties. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Eugeniu Rosca <erosca@de.adit-jv.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > --- > Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > index 9936b9ee67c3..d962138d5b50 100644 > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > @@ -16,6 +16,7 @@ Required properties: > "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. > "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. > "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. I was wondering why you didn't have a patch adding support for R8A77965. I see it is already added here but can't find a tree where this line exists (no linus/master or renesas-drivers/master). Did you maybe forgot to send out a patch? > + "renesas,can-r8a77990" if CAN controller is a part of R8A77990 SoC. > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > compatible device. > @@ -37,7 +38,7 @@ Required properties: > - pinctrl-0: pin control group to be used for this controller. > - pinctrl-names: must be "default". > > -Required properties for R8A7795, R8A7796 and R8A77965: > +Required properties for R8A7795, R8A7796, R8A77965 and R8A77990: > For the denoted SoCs, "clkp2" can be CANFD clock. This is a div6 clock and can > be used by both CAN and CAN FD controller at the same time. It needs to be > scaled to maximum frequency if any of these controllers use it. This is done > -- > 2.18.0 >
On 11/19/2018 12:14 AM, Wolfram Sang wrote: > On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: >> Document the support for rcar_can on R8A77990 SoC devices. >> Add R8A77990 to the list of SoCs which require the "assigned-clocks" >> and "assigned-clock-rates" properties. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Eugeniu Rosca <erosca@de.adit-jv.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Marc Kleine-Budde <mkl@pengutronix.de> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt >> index 9936b9ee67c3..d962138d5b50 100644 >> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt >> @@ -16,6 +16,7 @@ Required properties: >> "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. >> "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. >> "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. > > I was wondering why you didn't have a patch adding support for R8A77965. > I see it is already added here but can't find a tree where this line > exists (no linus/master or renesas-drivers/master). Did you maybe forgot > to send out a patch? Try and grep for 'renesas,rcar-gen3-can' , the drivers are in drivers/net/can/rcar/ . They both match on the generic compatible.
Hi Marek, Wolfram, On Mon, Nov 19, 2018 at 12:46 AM Marek Vasut <marek.vasut@gmail.com> wrote: > On 11/19/2018 12:14 AM, Wolfram Sang wrote: > > On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: > >> Document the support for rcar_can on R8A77990 SoC devices. > >> Add R8A77990 to the list of SoCs which require the "assigned-clocks" > >> and "assigned-clock-rates" properties. > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > >> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > >> @@ -16,6 +16,7 @@ Required properties: > >> "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. > >> "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. > >> "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. > > > > I was wondering why you didn't have a patch adding support for R8A77965. > > I see it is already added here but can't find a tree where this line > > exists (no linus/master or renesas-drivers/master). Did you maybe forgot > > to send out a patch? > > Try and grep for 'renesas,rcar-gen3-can' , the drivers are in > drivers/net/can/rcar/ . They both match on the generic compatible. Marek: I think you misunderstood Wolfram's question. He asked about the DT bindings, not about the driver. Wolfram: Eugenu's commit 4f145f14f6b98b5a ("dt-bindings: can: rcar_can: document r8a77965 support") is in next as of next-20181115 . However, it's not part of linux-can-next. Seems to be destined for v4.20 as a fix. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: > Document the support for rcar_can on R8A77990 SoC devices. > Add R8A77990 to the list of SoCs which require the "assigned-clocks" > and "assigned-clock-rates" properties. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Eugeniu Rosca <erosca@de.adit-jv.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > --- > Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> Marek: I think you misunderstood Wolfram's question. > He asked about the DT bindings, not about the driver. Exactly. > Wolfram: Eugenu's commit 4f145f14f6b98b5a ("dt-bindings: can: > rcar_can: document r8a77965 support") is in next as of next-20181115 . > However, it's not part of linux-can-next. Seems to be destined for v4.20 as > a fix. Thanks, Geert!
On 11/19/2018 10:38 AM, Geert Uytterhoeven wrote: > Hi Marek, Wolfram, Hi, > On Mon, Nov 19, 2018 at 12:46 AM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 11/19/2018 12:14 AM, Wolfram Sang wrote: >>> On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: >>>> Document the support for rcar_can on R8A77990 SoC devices. >>>> Add R8A77990 to the list of SoCs which require the "assigned-clocks" >>>> and "assigned-clock-rates" properties. >>>> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >>>> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt >>>> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt >>>> @@ -16,6 +16,7 @@ Required properties: >>>> "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. >>>> "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. >>>> "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. >>> >>> I was wondering why you didn't have a patch adding support for R8A77965. >>> I see it is already added here but can't find a tree where this line >>> exists (no linus/master or renesas-drivers/master). Did you maybe forgot >>> to send out a patch? >> >> Try and grep for 'renesas,rcar-gen3-can' , the drivers are in >> drivers/net/can/rcar/ . They both match on the generic compatible. > > Marek: I think you misunderstood Wolfram's question. > He asked about the DT bindings, not about the driver. Ha, yes, I think I did. > Wolfram: Eugenu's commit 4f145f14f6b98b5a ("dt-bindings: can: > rcar_can: document r8a77965 support") is in next as of next-20181115 . > However, it's not part of linux-can-next. Seems to be destined for v4.20 as > a fix. I'm always building on top of next, so that's why I didn't quite understand the question.
On Mon, Nov 19, 2018 at 10:38 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Wolfram: Eugenu's commit 4f145f14f6b98b5a ("dt-bindings: can: > rcar_can: document r8a77965 support") is in next as of next-20181115 . > However, it's not part of linux-can-next. Seems to be destined for v4.20 as > a fix. ... which has just landed in Linus' tree. Gr{oetje,eeting}s, Geert
On Sun, 18 Nov 2018 18:30:56 +0100, Marek Vasut wrote: > Document the support for rcar_can on R8A77990 SoC devices. > Add R8A77990 to the list of SoCs which require the "assigned-clocks" > and "assigned-clock-rates" properties. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Eugeniu Rosca <erosca@de.adit-jv.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > --- > Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 11/19/18 11:42 AM, Simon Horman wrote: > On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: >> Document the support for rcar_can on R8A77990 SoC devices. >> Add R8A77990 to the list of SoCs which require the "assigned-clocks" >> and "assigned-clock-rates" properties. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Eugeniu Rosca <erosca@de.adit-jv.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Marc Kleine-Budde <mkl@pengutronix.de> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > This patch seems to be missing upstream ?
On Sat, Feb 16, 2019 at 2:58 PM Marek Vasut <marek.vasut@gmail.com> wrote: > On 11/19/18 11:42 AM, Simon Horman wrote: > > On Sun, Nov 18, 2018 at 06:30:56PM +0100, Marek Vasut wrote: > >> Document the support for rcar_can on R8A77990 SoC devices. > >> Add R8A77990 to the list of SoCs which require the "assigned-clocks" > >> and "assigned-clock-rates" properties. > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Cc: Eugeniu Rosca <erosca@de.adit-jv.com> > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > >> Cc: Marc Kleine-Budde <mkl@pengutronix.de> > >> Cc: Rob Herring <robh@kernel.org> > >> Cc: Simon Horman <horms+renesas@verge.net.au> > >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > >> Cc: linux-renesas-soc@vger.kernel.org > >> --- > >> Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > This patch seems to be missing upstream ? Thanks, queuing in renesas-devel for v5.4. Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt index 9936b9ee67c3..d962138d5b50 100644 --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt @@ -16,6 +16,7 @@ Required properties: "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. + "renesas,can-r8a77990" if CAN controller is a part of R8A77990 SoC. "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 compatible device. @@ -37,7 +38,7 @@ Required properties: - pinctrl-0: pin control group to be used for this controller. - pinctrl-names: must be "default". -Required properties for R8A7795, R8A7796 and R8A77965: +Required properties for R8A7795, R8A7796, R8A77965 and R8A77990: For the denoted SoCs, "clkp2" can be CANFD clock. This is a div6 clock and can be used by both CAN and CAN FD controller at the same time. It needs to be scaled to maximum frequency if any of these controllers use it. This is done
Document the support for rcar_can on R8A77990 SoC devices. Add R8A77990 to the list of SoCs which require the "assigned-clocks" and "assigned-clock-rates" properties. Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Eugeniu Rosca <erosca@de.adit-jv.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: Rob Herring <robh@kernel.org> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-renesas-soc@vger.kernel.org --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)