| Message ID | 20181119035131.11255-6-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve I/O priority handling | expand |
On Mon, Nov 19, 2018 at 12:51:29PM +0900, Damien Le Moal wrote: > For cases when the application does not specify aio_reqprio for an aio, > fallback to use get_current_ioprio() to obtain the task I/O priority > last set using ioprio_set() rather than the hardcoded IOPRIO_CLASS_NONE > value. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good, Reiewed-by: Johannes Thumshirn <jthumshirn@suse.de>
On Mon, 2018-11-19 at 12:51 +0900, Damien Le Moal wrote: > For cases when the application does not specify aio_reqprio for an > aio, > fallback to use get_current_ioprio() to obtain the task I/O priority > last set using ioprio_set() rather than the hardcoded > IOPRIO_CLASS_NONE > value. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> Looks good, Reviewed-by: Adam Manzanares <adam.manzanares@wdc.com> > --- > fs/aio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 301e6314183b..b984918be4b7 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1441,7 +1441,7 @@ static int aio_prep_rw(struct kiocb *req, > struct iocb *iocb) > > req->ki_ioprio = iocb->aio_reqprio; > } else > - req->ki_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, > 0); > + req->ki_ioprio = get_current_ioprio(); > > ret = kiocb_set_rw_flags(req, iocb->aio_rw_flags); > if (unlikely(ret))
diff --git a/fs/aio.c b/fs/aio.c index 301e6314183b..b984918be4b7 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1441,7 +1441,7 @@ static int aio_prep_rw(struct kiocb *req, struct iocb *iocb) req->ki_ioprio = iocb->aio_reqprio; } else - req->ki_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0); + req->ki_ioprio = get_current_ioprio(); ret = kiocb_set_rw_flags(req, iocb->aio_rw_flags); if (unlikely(ret))
For cases when the application does not specify aio_reqprio for an aio, fallback to use get_current_ioprio() to obtain the task I/O priority last set using ioprio_set() rather than the hardcoded IOPRIO_CLASS_NONE value. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)