usb: misc: fix boolconv.cocci warnings
diff mbox series

Message ID alpine.DEB.2.21.1811211832430.2779@hadrien
State New, archived
Headers show
Series
  • usb: misc: fix boolconv.cocci warnings
Related show

Commit Message

Julia Lawall Nov. 21, 2018, 5:33 p.m. UTC
From: kbuild test robot <fengguang.wu@intel.com>

drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")
CC: Anatolij Gustschin <agust@denx.de>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signd-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

url:    https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ft232h-intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

gregkh@linuxfoundation.org Nov. 23, 2018, 3:10 p.m. UTC | #1
On Wed, Nov 21, 2018 at 06:33:51PM +0100, Julia Lawall wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> 
> drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here
> 
>  Remove unneeded conversion to bool
> 
> Semantic patch information:
>  Relational and logical operators evaluate to bool,
>  explicit conversion is overly verbose and unneeded.
> 
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> 
> Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")

I can't find this commit anywhere, nor the file that this patch touches.

What tree is it in?

thanks,

greg k-h
Anatolij Gustschin Nov. 23, 2018, 3:29 p.m. UTC | #2
On Fri, 23 Nov 2018 16:10:54 +0100
Greg KH gregkh@linuxfoundation.org wrote:
...
>> Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")  
>
>I can't find this commit anywhere, nor the file that this patch touches.
>
>What tree is it in?

This new driver was submitted to the lists and is not in mainline
tree yet. It was committed to some tree for build testing the
submitted patches, it seems.

Thanks,

Anatolij

Patch
diff mbox series

--- a/drivers/usb/misc/ft232h-intf.c
+++ b/drivers/usb/misc/ft232h-intf.c
@@ -813,7 +813,7 @@  static int ftdi_mpsse_gpio_get(struct gp

 	dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset);

-	low = offset < 5 ? true : false;
+	low = offset < 5;

 	mutex_lock(&priv->ops_mutex);