From patchwork Sun Nov 25 11:06:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= X-Patchwork-Id: 10696761 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 129A75A4 for ; Sun, 25 Nov 2018 11:07:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F36E029CBB for ; Sun, 25 Nov 2018 11:07:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E7B9D29CC9; Sun, 25 Nov 2018 11:07:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B844429CC4 for ; Sun, 25 Nov 2018 11:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbeKYV54 (ORCPT ); Sun, 25 Nov 2018 16:57:56 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35683 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbeKYV54 (ORCPT ); Sun, 25 Nov 2018 16:57:56 -0500 Received: by mail-pg1-f193.google.com with SMTP id s198so4836838pgs.2 for ; Sun, 25 Nov 2018 03:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=sqeG4n4uvzBIA11khEuqHQiSaOWodWQxW6OxwPnpJMc=; b=ODTJiLM2cnMvf1n0IiWVlxBsyI3QDgeloqhA+o1xNglZh5fh8m3Svu28jMs0EZ7217 7U1SKyUNHIUOABecQKJJiX8WrU0uy50YpFMzHIjO5S5pwoQFe26AvcBQ59+lWNqN9XOA 3ZHg7IpQkwoQXX4ReETcV4KB/gA2GdgwTM6BD283KAQOX1tfkmA2neA1rAk/XwZXEHK0 cGqBx/rYpB0oL7HcPmnx7At4l8Me6sn+baNvJYpBZieGTApjo40MOaXUCJwZTTGYYvf6 YdU/PeLDfXS7bknnXWiOPb2EjuzRIj50da+HEMRgBblPsf2mziHHWGo4GW67U968b636 gTDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sqeG4n4uvzBIA11khEuqHQiSaOWodWQxW6OxwPnpJMc=; b=YIbH8QGnja0V17WPDHVVLGFofejdN53BTIxiSCjzeCTxSHU6dlEmweoFA+fbBdBJc0 GeinZT6KnKVSwyqI7OnyERUN73u0AiZsRl4u/BdEjYYg3oICuxudXiZMR1Bx1bXHUZlK kAXAkyMtYvhJWxIDabm7FfJLKFGgpkNXMBUmCLpgBdPmLyYK/Oax6ttzu6ssZFCPGYxy ZTy7W9yU+2aNbTeRpTKmMZt2YQklyzqnMUTo+2zg6tN0HUf8f0g9sGd7660Y1sJVN2UW lQxllITu6Fv9PJYh7Fm6CUVO29DMPt3vPnWp9VtOlS6f4NWGucc48OWiLSWx38bhy4EU +KQQ== X-Gm-Message-State: AGRZ1gL+mz6D5gSy5/CeQfgWXpRh1/K4HaUVtsmFFUhFps1xNy0Sslvi hhVHbex+7IKu8AFqVrPZXApvMVfF X-Google-Smtp-Source: AJdET5c/NREzOxo4HWqwgkKJ6FReuxho/VHBsFE2i/u45d2CYj4jpnRqB0pxAchi2oUnvVNnxMyWEQ== X-Received: by 2002:a62:6204:: with SMTP id w4mr23461381pfb.5.1543144025814; Sun, 25 Nov 2018 03:07:05 -0800 (PST) Received: from localhost.localdomain ([136.179.21.64]) by smtp.gmail.com with ESMTPSA id h15sm21154301pgl.43.2018.11.25.03.07.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Nov 2018 03:07:05 -0800 (PST) From: =?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= To: git@vger.kernel.org Subject: [RFC PATCH 2/7] t0301: remove trailing / for dir creation Date: Sun, 25 Nov 2018 03:06:45 -0800 Message-Id: X-Mailer: git-send-email 2.20.0.rc1 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP the semantics of how mkdir -p should work, specially when using -m are not standard and in this case NetBSD will assume that the permision should not be changed, breaking the test -p is technically not needed either, but will be cleared in a future patch eventhough it could be considered an alternative fix Signed-off-by: Carlo Marcelo Arenas Belón --- t/t0301-credential-cache.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t0301-credential-cache.sh b/t/t0301-credential-cache.sh index fd92533acf..9529c612af 100755 --- a/t/t0301-credential-cache.sh +++ b/t/t0301-credential-cache.sh @@ -77,9 +77,9 @@ test_expect_success "use custom XDG_CACHE_HOME even if xdg socket exists" ' test_expect_success 'use user socket if user directory exists' ' test_when_finished " git credential-cache exit && - rmdir \"\$HOME/.git-credential-cache/\" + rmdir \"\$HOME/.git-credential-cache\" " && - mkdir -p -m 700 "$HOME/.git-credential-cache/" && + mkdir -p -m 700 "$HOME/.git-credential-cache" && check approve cache <<-\EOF && protocol=https host=example.com @@ -92,10 +92,10 @@ test_expect_success 'use user socket if user directory exists' ' test_expect_success SYMLINKS 'use user socket if user directory is a symlink to a directory' ' test_when_finished " git credential-cache exit && - rmdir \"\$HOME/dir/\" && + rmdir \"\$HOME/dir\" && rm \"\$HOME/.git-credential-cache\" " && - mkdir -p -m 700 "$HOME/dir/" && + mkdir -p -m 700 "$HOME/dir" && ln -s "$HOME/dir" "$HOME/.git-credential-cache" && check approve cache <<-\EOF && protocol=https