[for-3.1,13/25] MAINTAINERS: Add missing entries to VFIO
diff mbox series

Message ID 20181125205000.10324-14-philmd@redhat.com
State New
Headers show
Series
  • MAINTAINERS: Add various missing entries
Related show

Commit Message

Philippe Mathieu-Daudé Nov. 25, 2018, 8:49 p.m. UTC
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Huth Nov. 27, 2018, 7:14 a.m. UTC | #1
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h
> +F: docs/igd-assign.txt

Sounds reasonable to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Laurent Vivier Nov. 27, 2018, 11:41 a.m. UTC | #2
On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h
> +F: docs/igd-assign.txt
>  
>  vfio-ccw
>  M: Cornelia Huck <cohuck@redhat.com>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent
Alex Williamson Nov. 27, 2018, 4:35 p.m. UTC | #3
On Sun, 25 Nov 2018 21:49:48 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h

This misses util/vfio-helpers.c, both of which are contributed by Fam
and currently only used by nvme.  I really haven't done anything with
them, so they should probably be under the NVMe block driver, but if it
makes more sense for me to look after them, I can start paying more
attention to them.  I'm not sure signing someone up for new files
they've never touched counts as trivial ;)  Thanks,

Alex

> +F: docs/igd-assign.txt
>  
>  vfio-ccw
>  M: Cornelia Huck <cohuck@redhat.com>
Laurent Vivier Nov. 27, 2018, 4:50 p.m. UTC | #4
On 27/11/2018 17:35, Alex Williamson wrote:
> On Sun, 25 Nov 2018 21:49:48 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index bfe71f2555..e124792557 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>>  S: Supported
>>  F: hw/vfio/*
>>  F: include/hw/vfio/
>> +F: include/qemu/vfio-helpers.h
> 
> This misses util/vfio-helpers.c, both of which are contributed by Fam
> and currently only used by nvme.  I really haven't done anything with
> them, so they should probably be under the NVMe block driver, but if it
> makes more sense for me to look after them, I can start paying more
> attention to them.  I'm not sure signing someone up for new files
> they've never touched counts as trivial ;)  Thanks,

Un-applied to my trivial-patches branch...

Thanks,
Laurent
Philippe Mathieu-Daudé Nov. 27, 2018, 4:50 p.m. UTC | #5
On 27/11/18 17:35, Alex Williamson wrote:
> On Sun, 25 Nov 2018 21:49:48 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index bfe71f2555..e124792557 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>>  S: Supported
>>  F: hw/vfio/*
>>  F: include/hw/vfio/
>> +F: include/qemu/vfio-helpers.h
> 
> This misses util/vfio-helpers.c, both of which are contributed by Fam
> and currently only used by nvme.  I really haven't done anything with
> them, so they should probably be under the NVMe block driver, but if it
> makes more sense for me to look after them, I can start paying more
> attention to them.  I'm not sure signing someone up for new files
> they've never touched counts as trivial ;)  Thanks,

OK (Cc'ed Fam).

Laurent, can you unqueue this patch? (sorry).

Thanks,

Phil.

> 
> Alex
> 
>> +F: docs/igd-assign.txt
>>  
>>  vfio-ccw
>>  M: Cornelia Huck <cohuck@redhat.com>
>

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index bfe71f2555..e124792557 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1326,6 +1326,8 @@  M: Alex Williamson <alex.williamson@redhat.com>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <cohuck@redhat.com>