[for-3.1,22/25] MAINTAINERS: Add a missing entry to the New World machines
diff mbox series

Message ID 20181125205000.10324-23-philmd@redhat.com
State New
Headers show
Series
  • MAINTAINERS: Add various missing entries
Related show

Commit Message

Philippe Mathieu-Daudé Nov. 25, 2018, 8:49 p.m. UTC
The CHRP NVRAM has his own section, but since the New World
section contains the mac_nvram.c, it makes sens to also monitor
the corresponding header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth Nov. 27, 2018, 7:22 a.m. UTC | #1
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> The CHRP NVRAM has his own section, but since the New World
> section contains the mac_nvram.c, it makes sens to also monitor
> the corresponding header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92691589b1..a248c8c564 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
>  F: include/hw/misc/macio/
>  F: include/hw/misc/mos6522.h
>  F: include/hw/ppc/mac_dbdma.h
> +F: include/hw/nvram/chrp_nvram.h

I don't see the point why we should add duplicated entries here? The
header is also used by the Sparc machines, so why should this be added
additionally to the Mac machines only here, too? I suggest to drop this
patch.

 Thomas
Philippe Mathieu-Daudé Nov. 27, 2018, 9:26 a.m. UTC | #2
On 27/11/18 8:22, Thomas Huth wrote:
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> The CHRP NVRAM has his own section, but since the New World
>> section contains the mac_nvram.c, it makes sens to also monitor
>> the corresponding header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 92691589b1..a248c8c564 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
>>  F: include/hw/misc/macio/
>>  F: include/hw/misc/mos6522.h
>>  F: include/hw/ppc/mac_dbdma.h
>> +F: include/hw/nvram/chrp_nvram.h
> 
> I don't see the point why we should add duplicated entries here? The
> header is also used by the Sparc machines, so why should this be added
> additionally to the Mac machines only here, too? I suggest to drop this
> patch.

OK, will drop.

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index 92691589b1..a248c8c564 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -930,6 +930,7 @@  F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
+F: include/hw/nvram/chrp_nvram.h
 
 Old World
 M: David Gibson <david@gibson.dropbear.id.au>