diff mbox series

[v3] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop

Message ID 1543257648-105480-1-git-send-email-gkumar@neverware.com (mailing list archive)
State New, archived
Headers show
Series [v3] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop | expand

Commit Message

Girija Kumar Kasinadhuni Nov. 26, 2018, 6:40 p.m. UTC
This device makes a loud buzzing sound when a headphone is inserted while
playing audio at full volume through the speaker.

Signed-off-by: Girija Kumar Kasinadhuni <gkumar@neverware.com>
---
Apologies for the earlier patch not being tested properly. Verified this
time, and on the actual hardware. Here' s the alsa-info output.
http://www.alsa-project.org/db/?f=16bc34d9bf8c9b2536969c125c1721fee570c9b0

 sound/pci/hda/patch_realtek.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Takashi Iwai Nov. 27, 2018, 11:19 a.m. UTC | #1
On Mon, 26 Nov 2018 19:40:46 +0100,
Girija Kumar Kasinadhuni wrote:
> 
> This device makes a loud buzzing sound when a headphone is inserted while
> playing audio at full volume through the speaker.
> 
> Signed-off-by: Girija Kumar Kasinadhuni <gkumar@neverware.com>
> ---
> Apologies for the earlier patch not being tested properly. Verified this
> time, and on the actual hardware. Here' s the alsa-info output.
> http://www.alsa-project.org/db/?f=16bc34d9bf8c9b2536969c125c1721fee570c9b0

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 970bc44..c39f7f2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5495,6 +5495,7 @@  enum {
 	ALC255_FIXUP_DELL_HEADSET_MIC,
 	ALC295_FIXUP_HP_X360,
 	ALC221_FIXUP_HP_HEADSET_MIC,
+	ALC295_FIXUP_HP_AUTO_MUTE,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -5659,6 +5660,8 @@  static const struct hda_fixup alc269_fixups[] = {
 	[ALC269_FIXUP_HP_MUTE_LED_MIC3] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc269_fixup_hp_mute_led_mic3,
+		.chained = true,
+		.chain_id = ALC295_FIXUP_HP_AUTO_MUTE
 	},
 	[ALC269_FIXUP_HP_GPIO_LED] = {
 		.type = HDA_FIXUP_FUNC,
@@ -6362,6 +6365,10 @@  static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
+	[ALC295_FIXUP_HP_AUTO_MUTE] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc_fixup_auto_mute_via_amp,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {