From patchwork Tue Nov 27 05:56:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 10699751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A80314D6 for ; Tue, 27 Nov 2018 06:35:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F5C629165 for ; Tue, 27 Nov 2018 06:35:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 418C829347; Tue, 27 Nov 2018 06:35:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D7E629165 for ; Tue, 27 Nov 2018 06:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbeK0RcC (ORCPT ); Tue, 27 Nov 2018 12:32:02 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:59531 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727684AbeK0RcC (ORCPT ); Tue, 27 Nov 2018 12:32:02 -0500 X-IronPort-AV: E=Sophos;i="5.56,285,1539619200"; d="scan'208";a="48730844" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Nov 2018 14:35:11 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id D883C4B7349D; Tue, 27 Nov 2018 14:35:06 +0800 (CST) Received: from RHEL7U5GA_Intel64.g08.fujitsu.local (10.167.220.156) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 27 Nov 2018 14:35:10 +0800 From: Xiao Yang To: CC: , Xiao Yang Subject: [PATCH] xfs/111: Filter a "Structure needs cleaning" error from xfs_fsr Date: Tue, 27 Nov 2018 13:56:15 +0800 Message-ID: <1543298175-5405-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.167.220.156] X-yoursite-MailScanner-ID: D883C4B7349D.A8030 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP on upstream kernel, running xfs/111 got the following error: ------------------------------------------------- +xfs_fsr: xfs_bulkstat: Structure needs cleaning ------------------------------------------------- Since kernel commit 29cad0b, we don't convert a -EFSCORRUPTED error to -EINVAL in xfs_imap_to_bp() if we are doing an untrusted lookup. So xfs_bulkstat() called by xfs_fsr command fails and returns EFSCORRUPTED. We think it is reasonable for xfs_fsr to report EFSCORRUPTED because some inodes are actually corrupted. Signed-off-by: Xiao Yang --- tests/xfs/111 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/xfs/111 b/tests/xfs/111 index 2ef69f0..2bcf002 100755 --- a/tests/xfs/111 +++ b/tests/xfs/111 @@ -58,7 +58,8 @@ _try_scratch_mount || _fail "Couldn't mount after itrash" echo Attempting bulkstat #src/bstat -q $SCRATCH_MNT -$XFS_FSR_PROG $SCRATCH_MNT | _filter_scratch +#Since kernel commit 29cad0b, xfs_fsr reports a "Structure needs cleaning" error +$XFS_FSR_PROG $SCRATCH_MNT | _filter_scratch | grep -v "Structure needs cleaning" # Fix up intentional corruption so test can pass _scratch_unmount