| Message ID | 20181127142855.73899-5-heikki.krogerus@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | device property: Add fwnode_get_name() helper | expand |
On Tue, Nov 27, 2018 at 05:28:55PM +0300, Heikki Krogerus wrote: > This will prepare the device connection API for connections > described in firmware. This one does not belong to this series, sorry. Please skip it, or if you prefer, I'll resend. thanks,
On Tue, Nov 27, 2018 at 04:32:37PM +0200, Heikki Krogerus wrote: > On Tue, Nov 27, 2018 at 05:28:55PM +0300, Heikki Krogerus wrote: > > This will prepare the device connection API for connections > > described in firmware. > > This one does not belong to this series, sorry. Please skip it, or if > you prefer, I'll resend. Please, resend. It would reduce amount of confusion, Otherwise the series looks good to me. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Tue, Nov 27, 2018 at 05:07:56PM +0200, Andy Shevchenko wrote: > On Tue, Nov 27, 2018 at 04:32:37PM +0200, Heikki Krogerus wrote: > > On Tue, Nov 27, 2018 at 05:28:55PM +0300, Heikki Krogerus wrote: > > > This will prepare the device connection API for connections > > > described in firmware. > > > > This one does not belong to this series, sorry. Please skip it, or if > > you prefer, I'll resend. > > Please, resend. It would reduce amount of confusion, > > Otherwise the series looks good to me. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Sure. I'll resend. Thanks Andy! br,
diff --git a/include/linux/device.h b/include/linux/device.h index 1b25c7a43f4c..25e0409e0b0c 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -757,11 +757,17 @@ struct device_dma_parameters { /** * struct device_connection - Device Connection Descriptor + * @fwnode: The device node of the connected device * @endpoint: The names of the two devices connected together * @id: Unique identifier for the connection * @list: List head, private, for internal use only + * + * NOTE: @fwnode is not used together with @endpoint. @fwnode is used when + * platform firmware defines the connection. When the connection is registeded + * with device_connection_add() @endpoint is used instead. */ struct device_connection { + struct fwnode_handle *fwnode; const char *endpoint[2]; const char *id; struct list_head list;
This will prepare the device connection API for connections described in firmware. Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> --- include/linux/device.h | 6 ++++++ 1 file changed, 6 insertions(+)