diff mbox series

drm/i915/icl: Remove Wa_1604302699

Message ID 20181129134630.8222-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/icl: Remove Wa_1604302699 | expand

Commit Message

Tvrtko Ursulin Nov. 29, 2018, 1:46 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

It seems that the documentation does not reference this any more, plus,
bit 28 does not stick when written to the register.

Therefore I can only assume this is something which was documented in the
past but got removed from the hardware in the meantime.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Mika Kuoppala Nov. 29, 2018, 1:56 p.m. UTC | #1 
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> writes:

> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It seems that the documentation does not reference this any more, plus,
> bit 28 does not stick when written to the register.
>
> Therefore I can only assume this is something which was documented in the
> past but got removed from the hardware in the meantime.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index 39cd1f823ea9..e5cd6c6c66c3 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -882,11 +882,6 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
>  		   I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
>  		   GWUNIT_CLKGATE_DIS);
>  
> -	/* Wa_1604302699:icl */
> -	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
> -		   I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
> -		   GEN11_I2M_WRITE_DISABLE);
> -
>  	/* Wa_1406838659:icl (pre-prod) */
>  	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
>  		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,
> -- 
> 2.19.1
Tvrtko Ursulin Nov. 30, 2018, 3:10 p.m. UTC | #2 
On 29/11/2018 14:47, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/icl: Remove Wa_1604302699
> URL   : https://patchwork.freedesktop.org/series/53244/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5222 -> Patchwork_10955
> ====================================================
> 
> Summary
> -------
> 
>    **WARNING**
> 
>    Minor unknown changes coming with Patchwork_10955 need to be verified
>    manually.
>    
>    If you think the reported changes have nothing to do with the changes
>    introduced in Patchwork_10955, please notify your bug team to allow them
>    to document this new failure mode, which will reduce false positives in CI.
> 
>    External URL: https://patchwork.freedesktop.org/api/1.0/series/53244/revisions/1/mbox/
> 
> Possible new issues
> -------------------
> 
>    Here are the unknown changes that may have been introduced in Patchwork_10955:
> 
> ### IGT changes ###
> 
> #### Warnings ####
> 
>    * igt@prime_vgem@basic-fence-flip:
>      - fi-ivb-3520m:       SKIP -> PASS
> 
>    
> Known issues
> ------------
> 
>    Here are the changes found in Patchwork_10955 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>    * igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
>      - fi-skl-guc:         PASS -> FAIL [fdo#103191] / [fdo#107362]
> 
>    * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
>      - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]
> 
>    
> #### Possible fixes ####
> 
>    * igt@gem_mmap_gtt@basic:
>      - fi-glk-dsi:         INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
> 
>    
>    [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
>    [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>    [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
>    [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (49 -> 41)
> ------------------------------
> 
>    Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510
> 
> 
> Build changes
> -------------
> 
>      * Linux: CI_DRM_5222 -> Patchwork_10955
> 
>    CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_10955: 11100b9f61c3f4c893fdd337b2fa733ee3cdce02 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> 11100b9f61c3 drm/i915/icl: Remove Wa_1604302699

Pushed, thanks for review!

Regards,

Tvrtko
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
index 39cd1f823ea9..e5cd6c6c66c3 100644
--- a/drivers/gpu/drm/i915/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/intel_workarounds.c
@@ -882,11 +882,6 @@  static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
 		   I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
 		   GWUNIT_CLKGATE_DIS);
 
-	/* Wa_1604302699:icl */
-	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
-		   I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
-		   GEN11_I2M_WRITE_DISABLE);
-
 	/* Wa_1406838659:icl (pre-prod) */
 	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
 		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,