diff mbox series

ARM: dts: vf610-zii-scu4-aib: Add HI8435 support

Message ID 1543504220-10870-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: vf610-zii-scu4-aib: Add HI8435 support | expand

Commit Message

Fabio Estevam Nov. 29, 2018, 3:10 p.m. UTC
On the vf610-zii-scu4-aib board there is a hi8435 ( 32-channel
discrete-to-digital SPI sensor device) in the DSPI0 bus.

Add support for it.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Chris Healy Dec. 2, 2018, 7:22 p.m. UTC | #1
> On the vf610-zii-scu4-aib board there is a hi8435 ( 32-channel
> discrete-to-digital SPI sensor device) in the DSPI0 bus.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> index 52bac14..a1fd49e 100644
> --- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> +++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> @@ -397,6 +397,20 @@
>         };
>  };
>
> +&dspi0 {
> +       pinctrl-0 = <&pinctrl_dspi0>;

Reviewed-by: Chris Healy <cphealy@gmail.com>
Shawn Guo Dec. 5, 2018, 3:40 a.m. UTC | #2
On Thu, Nov 29, 2018 at 01:10:20PM -0200, Fabio Estevam wrote:
> On the vf610-zii-scu4-aib board there is a hi8435 ( 32-channel
> discrete-to-digital SPI sensor device) in the DSPI0 bus.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> index 52bac14..a1fd49e 100644
> --- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> +++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> @@ -397,6 +397,20 @@
>  	};
>  };
>  
> +&dspi0 {
> +	pinctrl-0 = <&pinctrl_dspi0>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +	bus-num = <0>;

We usually put 'status' at the bottom of property list.

> +
> +	hi8435@5 {

Can we have a generic name for the device?

Shawn

> +		compatible = "holt,hi8435";
> +		reg = <5>;
> +		gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>;
> +		spi-max-frequency = <1000000>;
> +	};
> +};
> +
>  &dspi1 {
>  	bus-num = <1>;
>  	pinctrl-names = "default";
> -- 
> 2.7.4
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
index 52bac14..a1fd49e 100644
--- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
+++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
@@ -397,6 +397,20 @@ 
 	};
 };
 
+&dspi0 {
+	pinctrl-0 = <&pinctrl_dspi0>;
+	pinctrl-names = "default";
+	status = "okay";
+	bus-num = <0>;
+
+	hi8435@5 {
+		compatible = "holt,hi8435";
+		reg = <5>;
+		gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>;
+		spi-max-frequency = <1000000>;
+	};
+};
+
 &dspi1 {
 	bus-num = <1>;
 	pinctrl-names = "default";