| Message ID | 20181129161513.31734-3-faiz_abbas@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add driver Support for MMCSD on AM654x. | expand |
On 29. 11. 18 17:15, Faiz Abbas wrote: > The "ti,am654-sdhci-5.1" binding has been moved to a new driver. Indicate > this by a deprecated message. > > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index e2effe17f05e..1edbb049cccb 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -16,6 +16,10 @@ Required Properties: > - "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1": rk3399 eMMC PHY > For this device it is strongly suggested to include arasan,soc-ctl-syscon. > - "ti,am654-sdhci-5.1", "arasan,sdhci-5.1": TI AM654 MMC PHY > + Note: This binding has been deprecated and moved to [5]. > + > + [5] Documentation/devicetree/bindings/mmc/sdhci-am654.txt > + > - reg: From mmc bindings: Register location and length. > - clocks: From clock bindings: Handles to clock inputs. > - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" > I would prefer if you can extend commit message by description you have in cover letter which explains reasons. When this is applied and someone look at git history none will understand from first read why you have done that. Thanks, Michal
Hi Michal, On 30/11/18 12:48 PM, Michal Simek wrote: > On 29. 11. 18 17:15, Faiz Abbas wrote: >> The "ti,am654-sdhci-5.1" binding has been moved to a new driver. Indicate >> this by a deprecated message. >> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >> --- >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index e2effe17f05e..1edbb049cccb 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -16,6 +16,10 @@ Required Properties: >> - "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1": rk3399 eMMC PHY >> For this device it is strongly suggested to include arasan,soc-ctl-syscon. >> - "ti,am654-sdhci-5.1", "arasan,sdhci-5.1": TI AM654 MMC PHY >> + Note: This binding has been deprecated and moved to [5]. >> + >> + [5] Documentation/devicetree/bindings/mmc/sdhci-am654.txt >> + >> - reg: From mmc bindings: Register location and length. >> - clocks: From clock bindings: Handles to clock inputs. >> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" >> > > I would prefer if you can extend commit message by description you have > in cover letter which explains reasons. When this is applied and someone > look at git history none will understand from first read why you have > done that. > Ok. Will add full explanations to both documentation patches. Thanks, Faiz
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index e2effe17f05e..1edbb049cccb 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -16,6 +16,10 @@ Required Properties: - "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1": rk3399 eMMC PHY For this device it is strongly suggested to include arasan,soc-ctl-syscon. - "ti,am654-sdhci-5.1", "arasan,sdhci-5.1": TI AM654 MMC PHY + Note: This binding has been deprecated and moved to [5]. + + [5] Documentation/devicetree/bindings/mmc/sdhci-am654.txt + - reg: From mmc bindings: Register location and length. - clocks: From clock bindings: Handles to clock inputs. - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
The "ti,am654-sdhci-5.1" binding has been moved to a new driver. Indicate this by a deprecated message. Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ 1 file changed, 4 insertions(+)