| Message ID | 1543578770-25708-1-git-send-email-jshekhar@codeaurora.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Headers | show |
| Series | [DPU] drm/msm/dpu: Ignore alpha for XBGR8888 format | expand |
On Fri, Nov 30, 2018 at 05:22:50PM +0530, Jayant Shekhar wrote: > Alpha enable in the pixel format will help in > selecting the blend rule. By keeping alpha enable > to true we are allowing foreground alpha to blend > with the layer. If alpha is don't care, then we > should not allow pixel alpha to be part of blend > equation. > > Signed-off-by: Jayant Shekhar <jshekhar@codeaurora.org> Pushed to dpu-staging/for-next. Thanks for your patch! Sean > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c > index bfcd165..d743e7c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c > @@ -216,7 +216,7 @@ struct dpu_media_color_map { > INTERLEAVED_RGB_FMT(XBGR8888, > COLOR_8BIT, COLOR_8BIT, COLOR_8BIT, COLOR_8BIT, > C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4, > - true, 4, 0, > + false, 4, 0, > DPU_FETCH_LINEAR, 1), > > INTERLEAVED_RGB_FMT(RGBA8888, > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index bfcd165..d743e7c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -216,7 +216,7 @@ struct dpu_media_color_map { INTERLEAVED_RGB_FMT(XBGR8888, COLOR_8BIT, COLOR_8BIT, COLOR_8BIT, COLOR_8BIT, C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4, - true, 4, 0, + false, 4, 0, DPU_FETCH_LINEAR, 1), INTERLEAVED_RGB_FMT(RGBA8888,
Alpha enable in the pixel format will help in selecting the blend rule. By keeping alpha enable to true we are allowing foreground alpha to blend with the layer. If alpha is don't care, then we should not allow pixel alpha to be part of blend equation. Signed-off-by: Jayant Shekhar <jshekhar@codeaurora.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)