diff mbox series

drm/i915/dp: Fix link compute m_n calc for DSC

Message ID 20181201010412.32372-1-manasi.d.navare@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/dp: Fix link compute m_n calc for DSC | expand

Commit Message

Navare, Manasi Dec. 1, 2018, 1:04 a.m. UTC
Fix the intel_link_compute_m_n in case of display stream
compression. This patch passes the compressed_bpp to
intel_link_compute_m_n if compression is enabled.

Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ville Syrjala Dec. 3, 2018, 12:05 p.m. UTC | #1
On Fri, Nov 30, 2018 at 05:04:12PM -0800, Manasi Navare wrote:
> Fix the intel_link_compute_m_n in case of display stream
> compression. This patch passes the compressed_bpp to
> intel_link_compute_m_n if compression is enabled.
> 
> Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 38a6e82153fd..a6907a1761ab 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2173,7 +2173,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>  				       &pipe_config->dp_m_n,
>  				       constant_n);
>  	else
> -		intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
> +		intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
>  				       pipe_config->lane_count,
>  				       adjusted_mode->crtc_clock,
>  				       pipe_config->port_clock,
> -- 
> 2.19.1
Navare, Manasi Dec. 3, 2018, 8:02 p.m. UTC | #2
Thanks fo rthe reviw, pushed to dinq!

Manasi


On Mon, Dec 03, 2018 at 02:05:42PM +0200, Ville Syrjälä wrote:
> On Fri, Nov 30, 2018 at 05:04:12PM -0800, Manasi Navare wrote:
> > Fix the intel_link_compute_m_n in case of display stream
> > compression. This patch passes the compressed_bpp to
> > intel_link_compute_m_n if compression is enabled.
> > 
> > Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 38a6e82153fd..a6907a1761ab 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2173,7 +2173,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> >  				       &pipe_config->dp_m_n,
> >  				       constant_n);
> >  	else
> > -		intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
> > +		intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
> >  				       pipe_config->lane_count,
> >  				       adjusted_mode->crtc_clock,
> >  				       pipe_config->port_clock,
> > -- 
> > 2.19.1
> 
> -- 
> Ville Syrjälä
> Intel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 38a6e82153fd..a6907a1761ab 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2173,7 +2173,7 @@  intel_dp_compute_config(struct intel_encoder *encoder,
 				       &pipe_config->dp_m_n,
 				       constant_n);
 	else
-		intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
+		intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
 				       pipe_config->lane_count,
 				       adjusted_mode->crtc_clock,
 				       pipe_config->port_clock,