| Message ID | 20181201100817.20688-3-oskari@lemmela.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: rockpro64 dts issues | expand |
On 12/1/2018 3:38 PM, Oskari Lemmela wrote: > Rockpro64 is not able boot if kernel is compiled with > CONFIG_DRM_ROCKCHIP=m > > Enable Rockpro64 board HDMI output to fix issue. Hi Oskari, Could you please describe this issue in detail. I am not able to reproduce this issue if CONFIG_DRM_ROCKCHIP is compile in or as a loadable module at the same time hdmi node is present or not. > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > index 5bd4d69914bd..be78172abc09 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > @@ -205,6 +205,13 @@ > status = "okay"; > }; > > +&hdmi { > + ddc-i2c-bus = <&i2c3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_cec>; > + status = "okay"; > +}; > + > &i2c0 { > clock-frequency = <400000>; > i2c-scl-rising-time-ns = <168>;
Am Mittwoch, 5. Dezember 2018, 14:03:29 CET schrieb agajjar: > > On 12/1/2018 3:38 PM, Oskari Lemmela wrote: > > Rockpro64 is not able boot if kernel is compiled with > > CONFIG_DRM_ROCKCHIP=m > > > > Enable Rockpro64 board HDMI output to fix issue. > > Hi Oskari, > > Could you please describe this issue in detail. > > I am not able to reproduce this issue if CONFIG_DRM_ROCKCHIP is compile > in or as a loadable module at the same time hdmi node is present or not. I've now simply adjusted the commit message to: "arm64: dts: rockchip: enable hdmi output on rk3399-rockpro64 The rockpro64 does have hdmi support, so add the necessary devicetree node to enable it." and applied it for 4.21. While it still would be good to find out where the issue comes from Oskari is seeing, the rockpro64 does have hdmi, so we can just enable it ;-) Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts index 5bd4d69914bd..be78172abc09 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts @@ -205,6 +205,13 @@ status = "okay"; }; +&hdmi { + ddc-i2c-bus = <&i2c3>; + pinctrl-names = "default"; + pinctrl-0 = <&hdmi_cec>; + status = "okay"; +}; + &i2c0 { clock-frequency = <400000>; i2c-scl-rising-time-ns = <168>;
Rockpro64 is not able boot if kernel is compiled with CONFIG_DRM_ROCKCHIP=m Enable Rockpro64 board HDMI output to fix issue. Signed-off-by: Oskari Lemmela <oskari@lemmela.net> --- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 7 +++++++ 1 file changed, 7 insertions(+)