[1/3] ACPI / APD: Add clock frequency for Hisilicon Hip08 SPI controller
diff mbox series

Message ID 1543806951-61848-2-git-send-email-f.fangjian@huawei.com
State New, archived
Headers show
Series
  • spi: dw-mmio: add ACPI support
Related show

Commit Message

Jay Fang Dec. 3, 2018, 3:15 a.m. UTC
SPI clock frequency of Designware ip for Hisilicon Hip08 is 250M. The
ACPI ID used is "HISI0173".

Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/acpi/acpi_apd.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rafael J. Wysocki Dec. 3, 2018, 9 a.m. UTC | #1
On Mon, Dec 3, 2018 at 4:15 AM Jay Fang <f.fangjian@huawei.com> wrote:
>
> SPI clock frequency of Designware ip for Hisilicon Hip08 is 250M. The
> ACPI ID used is "HISI0173".
>
> Signed-off-by: Jay Fang <f.fangjian@huawei.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

in case you want the whole series to go into the SPI tree.

Or please let me know if you want me to take this patch.

> ---
>  drivers/acpi/acpi_apd.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 2664452..ddf598a 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -166,6 +166,11 @@ static const struct apd_device_desc thunderx2_i2c_desc = {
>         .setup = acpi_apd_setup,
>         .fixed_clk_rate = 125000000,
>  };
> +
> +static const struct apd_device_desc hip08_spi_desc = {
> +       .setup = acpi_apd_setup,
> +       .fixed_clk_rate = 250000000,
> +};
>  #endif
>
>  #else
> @@ -234,6 +239,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>         { "CAV9007",  APD_ADDR(thunderx2_i2c_desc) },
>         { "HISI02A1", APD_ADDR(hip07_i2c_desc) },
>         { "HISI02A2", APD_ADDR(hip08_i2c_desc) },
> +       { "HISI0173", APD_ADDR(hip08_spi_desc) },
>  #endif
>         { }
>  };
> --
> 2.7.4
>
Mark Brown Dec. 4, 2018, 5:24 p.m. UTC | #2
On Mon, Dec 03, 2018 at 10:00:54AM +0100, Rafael J. Wysocki wrote:
> On Mon, Dec 3, 2018 at 4:15 AM Jay Fang <f.fangjian@huawei.com> wrote:
> >
> > SPI clock frequency of Designware ip for Hisilicon Hip08 is 250M. The
> > ACPI ID used is "HISI0173".
> >
> > Signed-off-by: Jay Fang <f.fangjian@huawei.com>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> in case you want the whole series to go into the SPI tree.
> 
> Or please let me know if you want me to take this patch.

There seems to be no build time dependency from the SPI side so you may
as well apply it to your tree to avoid the risk of conflicts.
Jay Fang Dec. 13, 2018, 11:12 a.m. UTC | #3
Hi, Rafael
Please take this patch, thank you.

On 2018/12/3 17:00, Rafael J. Wysocki wrote:
> On Mon, Dec 3, 2018 at 4:15 AM Jay Fang <f.fangjian@huawei.com> wrote:
>>
>> SPI clock frequency of Designware ip for Hisilicon Hip08 is 250M. The
>> ACPI ID used is "HISI0173".
>>
>> Signed-off-by: Jay Fang <f.fangjian@huawei.com>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> in case you want the whole series to go into the SPI tree.
> 
> Or please let me know if you want me to take this patch.
> 
>> ---
>>  drivers/acpi/acpi_apd.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
>> index 2664452..ddf598a 100644
>> --- a/drivers/acpi/acpi_apd.c
>> +++ b/drivers/acpi/acpi_apd.c
>> @@ -166,6 +166,11 @@ static const struct apd_device_desc thunderx2_i2c_desc = {
>>         .setup = acpi_apd_setup,
>>         .fixed_clk_rate = 125000000,
>>  };
>> +
>> +static const struct apd_device_desc hip08_spi_desc = {
>> +       .setup = acpi_apd_setup,
>> +       .fixed_clk_rate = 250000000,
>> +};
>>  #endif
>>
>>  #else
>> @@ -234,6 +239,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>>         { "CAV9007",  APD_ADDR(thunderx2_i2c_desc) },
>>         { "HISI02A1", APD_ADDR(hip07_i2c_desc) },
>>         { "HISI02A2", APD_ADDR(hip08_i2c_desc) },
>> +       { "HISI0173", APD_ADDR(hip08_spi_desc) },
>>  #endif
>>         { }
>>  };
>> --
>> 2.7.4
>>
> 
> .
>
Rafael J. Wysocki Dec. 13, 2018, 11:13 a.m. UTC | #4
On Thu, Dec 13, 2018 at 12:12 PM Fangjian (Turing)
<f.fangjian@huawei.com> wrote:
>
> Hi, Rafael
> Please take this patch, thank you.

Done already, thanks!

Patch
diff mbox series

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 2664452..ddf598a 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -166,6 +166,11 @@  static const struct apd_device_desc thunderx2_i2c_desc = {
 	.setup = acpi_apd_setup,
 	.fixed_clk_rate = 125000000,
 };
+
+static const struct apd_device_desc hip08_spi_desc = {
+	.setup = acpi_apd_setup,
+	.fixed_clk_rate = 250000000,
+};
 #endif
 
 #else
@@ -234,6 +239,7 @@  static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "CAV9007",  APD_ADDR(thunderx2_i2c_desc) },
 	{ "HISI02A1", APD_ADDR(hip07_i2c_desc) },
 	{ "HISI02A2", APD_ADDR(hip08_i2c_desc) },
+	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
 #endif
 	{ }
 };