| Message ID | 20181203064317.57054-1-wen.yang99@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev: fsl-diu: remove redundant null check on cmap | expand |
On 12/3/18 12:43 AM, Wen Yang wrote: > The null check on &info->cmap is redundant since cmap is a struct > inside fb_info and can never be null, so the check is always true. > we may remove it. > > Signed-off-by: Wen Yang<wen.yang99@zte.com.cn> Acked-by: Timur Tabi <timur@kernel.org>
On 12/03/2018 03:53 PM, Timur Tabi wrote: > On 12/3/18 12:43 AM, Wen Yang wrote: >> The null check on &info->cmap is redundant since cmap is a struct >> inside fb_info and can never be null, so the check is always true. >> we may remove it. >> >> Signed-off-by: Wen Yang<wen.yang99@zte.com.cn> > > Acked-by: Timur Tabi <timur@kernel.org> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index 332a56b6811f..9a5451ba4d44 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1575,8 +1575,7 @@ static void uninstall_fb(struct fb_info *info) unregister_framebuffer(info); unmap_video_memory(info); - if (&info->cmap) - fb_dealloc_cmap(&info->cmap); + fb_dealloc_cmap(&info->cmap); mfbi->registered = 0; }
The null check on &info->cmap is redundant since cmap is a struct inside fb_info and can never be null, so the check is always true. we may remove it. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> CC: Timur Tabi <timur@kernel.org> CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> CC: linux-fbdev@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: linux-kernel@vger.kernel.org --- drivers/video/fbdev/fsl-diu-fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)