mac80211: ignore NullFunc frames in the duplicate detection
diff mbox series

Message ID
State Accepted
Delegated to: Johannes Berg
Headers show
  • mac80211: ignore NullFunc frames in the duplicate detection
Related show

Commit Message

Emmanuel Grumbach Dec. 3, 2018, 7:16 p.m. UTC
NullFunc packets should never be duplicate just like
QoS-NullFunc packets.

We saw a client that enters / exits power save with
NullFunc frames (and not with QoS-NullFunc) despite the
fact that the association supports HT.
This specific client also re-uses a non-zero sequence number
for different NullFunc frames.
At some point, the client had to send a retransmission of
the NullFunc frame and we dropped it, leading to a
misalignment in the power save state.
Fix this by never consider a NullFunc frame as duplicate,
just like we do for QoS NullFunc frames.

This fixes

CC: <>
Signed-off-by: Emmanuel Grumbach <>
 net/mac80211/rx.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 3bd3b57..2c6515a 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -1403,6 +1403,7 @@  ieee80211_rx_h_check_dup(struct ieee80211_rx_data *rx)
 		return RX_CONTINUE;
 	if (ieee80211_is_ctl(hdr->frame_control) ||
+	    ieee80211_is_nullfunc(hdr->frame_control) ||
 	    ieee80211_is_qos_nullfunc(hdr->frame_control) ||
 		return RX_CONTINUE;