diff mbox series

[3/3] RelNotes 2.20: drop spurious double quote

Message ID 78f3043b6589f7e3b1872d940ae2ee1315553373.1543868120.git.martin.agren@gmail.com (mailing list archive)
State New, archived
Headers show
Series Re: [ANNOUNCE] Git v2.20.0-rc2 | expand

Commit Message

Martin Ågren Dec. 3, 2018, 8:21 p.m. UTC
We have three double-quote characters, which is one too many or too few.
Dropping the last one seems to match the original intention best.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 Documentation/RelNotes/2.20.0.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Junio C Hamano Dec. 4, 2018, 2:26 a.m. UTC | #1
Martin Ågren <martin.agren@gmail.com> writes:

> We have three double-quote characters, which is one too many or too few.
> Dropping the last one seems to match the original intention best.

Thanks for spotting.  The actual original intention was that the
user says two things:

	first saying "add only what does not match '*' out of all
	branches" and then saying "add all branches, without any
	exclusion this time".

But letting the user first say one thing and then doing another
thing without saying it is also fine, which is what your version is.



>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
>  Documentation/RelNotes/2.20.0.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/RelNotes/2.20.0.txt b/Documentation/RelNotes/2.20.0.txt
> index 201135d80c..e71fe3dee1 100644
> --- a/Documentation/RelNotes/2.20.0.txt
> +++ b/Documentation/RelNotes/2.20.0.txt
> @@ -578,7 +578,7 @@ Fixes since v2.19
>  
>   * "git rev-parse --exclude=* --branches --branches"  (i.e. first
>     saying "add only things that do not match '*' out of all branches"
> -   and then adding all branches, without any exclusion this time")
> +   and then adding all branches, without any exclusion this time)
>     worked as expected, but "--exclude=* --all --all" did not work the
>     same way, which has been fixed.
>     (merge 5221048092 ag/rev-parse-all-exclude-fix later to maint).
diff mbox series

Patch

diff --git a/Documentation/RelNotes/2.20.0.txt b/Documentation/RelNotes/2.20.0.txt
index 201135d80c..e71fe3dee1 100644
--- a/Documentation/RelNotes/2.20.0.txt
+++ b/Documentation/RelNotes/2.20.0.txt
@@ -578,7 +578,7 @@  Fixes since v2.19
 
  * "git rev-parse --exclude=* --branches --branches"  (i.e. first
    saying "add only things that do not match '*' out of all branches"
-   and then adding all branches, without any exclusion this time")
+   and then adding all branches, without any exclusion this time)
    worked as expected, but "--exclude=* --all --all" did not work the
    same way, which has been fixed.
    (merge 5221048092 ag/rev-parse-all-exclude-fix later to maint).