[VSP-Tests,6/7] vsp-lib: Support late queuing of buffers in yavta
diff mbox series

Message ID 20181204155146.9726-7-kieran.bingham@ideasonboard.com
State New
Delegated to: Kieran Bingham
Headers show
Series
  • Reset controls and unloved patches
Related show

Commit Message

Kieran Bingham Dec. 4, 2018, 3:51 p.m. UTC
Provide the pass-through option of --queue-late to vsp-runner, to request
that yavta will queue frames after the stream has started.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 scripts/vsp-lib.sh | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Laurent Pinchart Feb. 17, 2019, noon UTC | #1
Hi Kieran,

Thank you for the patch.

On Tue, Dec 04, 2018 at 03:51:45PM +0000, Kieran Bingham wrote:
> Provide the pass-through option of --queue-late to vsp-runner, to request
> that yavta will queue frames after the stream has started.

As with 5/7, what is the use case for this ?

> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  scripts/vsp-lib.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index 9140254c7459..3d2792707d24 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -898,6 +898,7 @@ vsp_runner() {
>  	local count=10
>  	local pause=
>  	local skip=7
> +	local queue_late=
>  
>  	for option in $* ; do
>  		case $option in
> @@ -916,6 +917,8 @@ vsp_runner() {
>  		--skip=*)
>  			skip=${option/--skip=/}
>  			;;
> +		--queue-late)
> +			queue_late=queue-late
>  
>  		*)
>  			return 1
> @@ -959,6 +962,7 @@ vsp_runner() {
>  
>  	$yavta -c$count -n $buffers ${format:+-f $format} ${size:+-s $size} \
>  		${skip:+--skip $skip} ${file:+--file=$file} ${pause:+-p$pause} \
> +		${queue_late:+--$queue_late} \
>  		$videodev | ./logger.sh $entity >> $logfile
>  }
>
Kieran Bingham Feb. 17, 2019, 8:57 p.m. UTC | #2
Hi Laurent,

On 17/02/2019 12:00, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Tue, Dec 04, 2018 at 03:51:45PM +0000, Kieran Bingham wrote:
>> Provide the pass-through option of --queue-late to vsp-runner, to request
>> that yavta will queue frames after the stream has started.
> 
> As with 5/7, what is the use case for this ?

I'm sure it had a very good use case at the time.
Please ask 2 months ago Kieran ... Current Kieran has no idea :)

And then let me borrow your time machine - I have some good uses for it :D

I remember asking  you about this option in fact, but I can't remember
what I was testing specifically, or why I have added this here.

Maybe I was using it to investigate something ... It might perhaps be
useful to add a test which uses this to make sure the VSP1 is happy with
late queued frames?

>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>> ---
>>  scripts/vsp-lib.sh | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
>> index 9140254c7459..3d2792707d24 100755
>> --- a/scripts/vsp-lib.sh
>> +++ b/scripts/vsp-lib.sh
>> @@ -898,6 +898,7 @@ vsp_runner() {
>>  	local count=10
>>  	local pause=
>>  	local skip=7
>> +	local queue_late=
>>  
>>  	for option in $* ; do
>>  		case $option in
>> @@ -916,6 +917,8 @@ vsp_runner() {
>>  		--skip=*)
>>  			skip=${option/--skip=/}
>>  			;;
>> +		--queue-late)
>> +			queue_late=queue-late

erm ... missing ";;"?

>>  
>>  		*)
>>  			return 1
>> @@ -959,6 +962,7 @@ vsp_runner() {
>>  
>>  	$yavta -c$count -n $buffers ${format:+-f $format} ${size:+-s $size} \
>>  		${skip:+--skip $skip} ${file:+--file=$file} ${pause:+-p$pause} \
>> +		${queue_late:+--$queue_late} \
>>  		$videodev | ./logger.sh $entity >> $logfile
>>  }
>>  
>
Laurent Pinchart Feb. 19, 2019, 4:37 p.m. UTC | #3
Hi Kieran,

On Sun, Feb 17, 2019 at 08:57:51PM +0000, Kieran Bingham wrote:
> On 17/02/2019 12:00, Laurent Pinchart wrote:
> > On Tue, Dec 04, 2018 at 03:51:45PM +0000, Kieran Bingham wrote:
> >> Provide the pass-through option of --queue-late to vsp-runner, to request
> >> that yavta will queue frames after the stream has started.
> > 
> > As with 5/7, what is the use case for this ?
> 
> I'm sure it had a very good use case at the time.
> Please ask 2 months ago Kieran ... Current Kieran has no idea :)
> 
> And then let me borrow your time machine - I have some good uses for it :D
> 
> I remember asking  you about this option in fact, but I can't remember
> what I was testing specifically, or why I have added this here.
> 
> Maybe I was using it to investigate something ... It might perhaps be
> useful to add a test which uses this to make sure the VSP1 is happy with
> late queued frames?

At least part of this is handled internally in videobuf2 without being
exposed to the VSP1 driver. If the exposed part is considered to be
possibly problematic then I would indeed prefer to add a specific test
to cover this.

> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> >> ---
> >>  scripts/vsp-lib.sh | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> >> index 9140254c7459..3d2792707d24 100755
> >> --- a/scripts/vsp-lib.sh
> >> +++ b/scripts/vsp-lib.sh
> >> @@ -898,6 +898,7 @@ vsp_runner() {
> >>  	local count=10
> >>  	local pause=
> >>  	local skip=7
> >> +	local queue_late=
> >>  
> >>  	for option in $* ; do
> >>  		case $option in
> >> @@ -916,6 +917,8 @@ vsp_runner() {
> >>  		--skip=*)
> >>  			skip=${option/--skip=/}
> >>  			;;
> >> +		--queue-late)
> >> +			queue_late=queue-late
> 
> erm ... missing ";;"?
> 
> >>  
> >>  		*)
> >>  			return 1
> >> @@ -959,6 +962,7 @@ vsp_runner() {
> >>  
> >>  	$yavta -c$count -n $buffers ${format:+-f $format} ${size:+-s $size} \
> >>  		${skip:+--skip $skip} ${file:+--file=$file} ${pause:+-p$pause} \
> >> +		${queue_late:+--$queue_late} \
> >>  		$videodev | ./logger.sh $entity >> $logfile
> >>  }
> >>

Patch
diff mbox series

diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
index 9140254c7459..3d2792707d24 100755
--- a/scripts/vsp-lib.sh
+++ b/scripts/vsp-lib.sh
@@ -898,6 +898,7 @@  vsp_runner() {
 	local count=10
 	local pause=
 	local skip=7
+	local queue_late=
 
 	for option in $* ; do
 		case $option in
@@ -916,6 +917,8 @@  vsp_runner() {
 		--skip=*)
 			skip=${option/--skip=/}
 			;;
+		--queue-late)
+			queue_late=queue-late
 
 		*)
 			return 1
@@ -959,6 +962,7 @@  vsp_runner() {
 
 	$yavta -c$count -n $buffers ${format:+-f $format} ${size:+-s $size} \
 		${skip:+--skip $skip} ${file:+--file=$file} ${pause:+-p$pause} \
+		${queue_late:+--$queue_late} \
 		$videodev | ./logger.sh $entity >> $logfile
 }