| Message ID | 20181205004823.30823-1-jose.souza@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking area | expand |
On Tue, 2018-12-04 at 16:48 -0800, José Roberto de Souza wrote: > GLK and CNL+ supports a bigger FBC tracking area. > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_fbc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c > b/drivers/gpu/drm/i915/intel_fbc.c > index f23570c44323..78dbacdeaece 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -626,7 +626,10 @@ static bool > intel_fbc_hw_tracking_covers_screen(struct intel_crtc *crtc) > struct intel_fbc *fbc = &dev_priv->fbc; > unsigned int effective_w, effective_h, max_w, max_h; > > - if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) { > + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) { > + max_w = 5120; > + max_h = 4096; Verified against bspec. Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > + } else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) { > max_w = 4096; > max_h = 4096; > } else if (IS_G4X(dev_priv) || INTEL_GEN(dev_priv) >= 5) {
On Wed, 2018-12-05 at 12:30 +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking area > URL : https://patchwork.freedesktop.org/series/53515/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5263_full -> Patchwork_11016_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_11016_full absolutely > need to be > verified manually. > > If you think the reported changes have nothing to do with the > changes > introduced in Patchwork_11016_full, please notify your bug team to > allow them > to document this new failure mode, which will reduce false > positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in > Patchwork_11016_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_cursor_legacy@pipe-a-torture-bo: > - shard-skl: PASS -> INCOMPLETE > > > #### Warnings #### > > * igt@kms > _frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu: > - shard-hsw: PASS -> SKIP +1 > This change only affects GLK and GEN10+ so this incomplete and skips are comming from other changes. Thanks for the review DK, patch merged to dinq. > > Known issues > ------------ > > Here are the changes found in Patchwork_11016_full that come from > known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_exec_schedule@pi-ringfull-blt: > - {shard-iclb}: NOTRUN -> FAIL [fdo#103158] > > * igt@gem_exec_schedule@pi-ringfull-render: > - shard-skl: NOTRUN -> FAIL [fdo#103158] +1 > > * igt@gem_exec_schedule@smoketest-all: > - shard-glk: PASS -> INCOMPLETE [fdo#103359] / > [k.org#198133] > > * igt@gem_ppgtt@blt-vs-render-ctxn: > - shard-skl: NOTRUN -> TIMEOUT [fdo#108039] > > * igt@gem_userptr_blits@readonly-unsync: > - shard-skl: NOTRUN -> TIMEOUT [fdo#108887] > > * igt@i915_suspend@shrink: > - shard-skl: NOTRUN -> DMESG-WARN [fdo#108784] > > * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a: > - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] > > * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b: > - {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107956] +1 > > * igt@kms_ccs@pipe-a-crc-sprite-planes-basic: > - shard-glk: PASS -> FAIL [fdo#108145] > > * igt@kms_ccs@pipe-c-crc-sprite-planes-basic: > - {shard-iclb}: NOTRUN -> FAIL [fdo#107725] +1 > > * igt@kms_color@pipe-c-ctm-max: > - shard-apl: PASS -> FAIL [fdo#108147] > > * igt@kms_cursor_crc@cursor-128x42-offscreen: > - shard-skl: PASS -> FAIL [fdo#103232] > > * igt@kms_cursor_crc@cursor-256x85-onscreen: > - shard-glk: PASS -> FAIL [fdo#103232] +2 > > * igt@kms_cursor_crc@cursor-256x85-sliding: > - {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +2 > > * igt@kms_cursor_crc@cursor-64x21-random: > - shard-apl: PASS -> FAIL [fdo#103232] +3 > > * igt@kms_cursor_crc@cursor-64x64-suspend: > - shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232] +1 > > * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled: > - shard-skl: PASS -> FAIL [fdo#103184] > > * igt@kms_fbcon_fbt@psr: > - shard-skl: NOTRUN -> FAIL [fdo#107882] > > * igt@kms_flip@flip-vs-expired-vblank: > - shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363] > > * igt@kms_flip_tiling@flip-to-y-tiled: > - shard-skl: PASS -> FAIL [fdo#107931] > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move: > - {shard-iclb}: PASS -> FAIL [fdo#103167] +3 > > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt: > - shard-glk: PASS -> FAIL [fdo#103167] +1 > > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-onoff: > - shard-hsw: PASS -> INCOMPLETE [fdo#103540] > > * igt@kms_frontbuffer_tracking@fbcpsr-stridechange: > - {shard-iclb}: PASS -> FAIL [fdo#105683] > > * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff: > - shard-skl: NOTRUN -> FAIL [fdo#103167] > > * {igt@kms_plane@pixel-format-pipe-a-planes-source-clamping}: > - shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1 > > * igt@kms_plane@pixel-format-pipe-b-planes: > - {shard-iclb}: NOTRUN -> FAIL [fdo#103166] > > * {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}: > - shard-apl: PASS -> FAIL [fdo#108948] > > * igt@kms_plane@plane-position-covered-pipe-b-planes: > - shard-apl: PASS -> FAIL [fdo#103166] > > * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: > - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] > > * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: > - shard-skl: NOTRUN -> FAIL [fdo#108145] > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: NOTRUN -> FAIL [fdo#107815] > > * igt@kms_plane_multiple@atomic-pipe-a-tiling-y: > - shard-glk: PASS -> FAIL [fdo#103166] +2 > > * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf: > - {shard-iclb}: PASS -> FAIL [fdo#103166] +2 > > * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format: > - {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107724] +1 > > * igt@kms_rmfb@close-fd: > - {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +3 > > * {igt@kms_rotation_crc@multiplane-rotation-cropping-top}: > - shard-kbl: PASS -> DMESG-WARN [fdo#105604] > > * igt@kms_setmode@basic: > - shard-skl: NOTRUN -> FAIL [fdo#99912] > > * igt@kms_sysfs_edid_timing: > - shard-skl: NOTRUN -> FAIL [fdo#100047] > > * igt@pm_rpm@dpms-mode-unset-lpsp: > - shard-skl: PASS -> INCOMPLETE [fdo#107807] > > * igt@pm_rpm@dpms-mode-unset-non-lpsp: > - shard-skl: NOTRUN -> INCOMPLETE [fdo#107807] > > > #### Possible fixes #### > > * igt@gem_mmap_gtt@hang: > - shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> > PASS > > * igt@kms > _atomic_transition@plane-all-modeset-transition-internal-panels: > - {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS +13 > > * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a: > - shard-hsw: DMESG-WARN [fdo#107956] -> PASS > > * igt@kms_cursor_crc@cursor-256x256-sliding: > - shard-skl: FAIL [fdo#103232] -> PASS > > * igt@kms_cursor_crc@cursor-256x256-suspend: > - shard-skl: INCOMPLETE [fdo#104108] -> PASS > > * igt@kms_cursor_legacy@all-pipes-torture-move: > - shard-hsw: DMESG-WARN [fdo#107122] -> PASS > > * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled: > - shard-skl: FAIL [fdo#103184] -> PASS > > * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled: > - shard-glk: FAIL [fdo#103184] -> PASS > > * igt@kms_fbcon_fbt@fbc-suspend: > - shard-skl: FAIL [fdo#103833] / [fdo#105682] -> PASS > > * igt@kms_flip@dpms-vs-vblank-race-interruptible: > - shard-hsw: DMESG-WARN [fdo#102614] -> PASS > > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: > - shard-glk: FAIL [fdo#103167] -> PASS +2 > > * igt@kms > _frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc: > - {shard-iclb}: DMESG-FAIL [fdo#107724] -> PASS +1 > > * igt@kms > _frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu: > - {shard-iclb}: FAIL [fdo#103167] -> PASS > > * {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}: > - shard-glk: FAIL [fdo#108948] -> PASS > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS > > * igt@kms_rotation_crc@primary-rotation-180: > - {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> > PASS +3 > > * igt@kms_setmode@basic: > - shard-apl: FAIL [fdo#99912] -> PASS > > * igt@perf_pmu@rc6-runtime-pm: > - shard-skl: FAIL [fdo#105010] -> PASS > > * igt@pm_rpm@legacy-planes-dpms: > - shard-skl: INCOMPLETE [fdo#105959] / [fdo#107807] -> > PASS > > * igt@pm_rpm@reg-read-ioctl: > - shard-skl: INCOMPLETE [fdo#107807] -> PASS > > > #### Warnings #### > > * igt@i915_selftest@live_contexts: > - {shard-iclb}: INCOMPLETE [fdo#108315] -> DMESG-FAIL > [fdo#108569] > > > {name}: This element is suppressed. This means it is ignored when > computing > the status of the difference (SUCCESS, WARNING, or > FAILURE). > > [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 > [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 > [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 > [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158 > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184 > [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 > [fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833 > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 > [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010 > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 > [fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604 > [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 > [fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683 > [fdo#105959]: https://bugs.freedesktop.org/show_bug.cgi?id=105959 > [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885 > [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122 > [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 > [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725 > [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 > [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 > [fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882 > [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931 > [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 > [fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147 > [fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315 > [fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336 > [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 > [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784 > [fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887 > [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948 > [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 > > > Participating hosts (7 -> 7) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * Linux: CI_DRM_5263 -> Patchwork_11016 > > CI_DRM_5263: 823664600f1dc6b351612283cd13836b0d768251 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_4740: dd8de0efa64e50bc06c2882a0028d98ad870e752 @ > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_11016: 9addfbef50be41d39ac03ef2c89ec6fa6dea7bf3 @ > git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11016/
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index f23570c44323..78dbacdeaece 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -626,7 +626,10 @@ static bool intel_fbc_hw_tracking_covers_screen(struct intel_crtc *crtc) struct intel_fbc *fbc = &dev_priv->fbc; unsigned int effective_w, effective_h, max_w, max_h; - if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) { + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) { + max_w = 5120; + max_h = 4096; + } else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) { max_w = 4096; max_h = 4096; } else if (IS_G4X(dev_priv) || INTEL_GEN(dev_priv) >= 5) {
GLK and CNL+ supports a bigger FBC tracking area. Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_fbc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)