diff mbox series

[v2] cpufreq: nforce2: Remove meaningless return

Message ID 20181205155751.15945-1-tiny.windzz@gmail.com (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show
Series [v2] cpufreq: nforce2: Remove meaningless return | expand

Commit Message

Yangtao Li Dec. 5, 2018, 3:57 p.m. UTC
Delete a line of meaningless return and some useless blank lines. In a function
whose return type is void, returning on the last line is not required.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
Changes in v2:
-revert modify of MODULE_
-delete some blank lines
---
 drivers/cpufreq/cpufreq-nforce2.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Viresh Kumar Dec. 6, 2018, 4:20 a.m. UTC | #1
On 05-12-18, 10:57, Yangtao Li wrote:
> Delete a line of meaningless return and some useless blank lines. In a function
> whose return type is void, returning on the last line is not required.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Changes in v2:
> -revert modify of MODULE_
> -delete some blank lines
> ---
>  drivers/cpufreq/cpufreq-nforce2.c | 3 ---
>  1 file changed, 3 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Rafael J. Wysocki Dec. 17, 2018, 11:44 a.m. UTC | #2
On Thursday, December 6, 2018 5:20:25 AM CET Viresh Kumar wrote:
> On 05-12-18, 10:57, Yangtao Li wrote:
> > Delete a line of meaningless return and some useless blank lines. In a function
> > whose return type is void, returning on the last line is not required.
> > 
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v2:
> > -revert modify of MODULE_
> > -delete some blank lines
> > ---
> >  drivers/cpufreq/cpufreq-nforce2.c | 3 ---
> >  1 file changed, 3 deletions(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Patch applied, thanks!
diff mbox series

Patch

diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nforce2.c
index dbf82f36d270..33c309a08c64 100644
--- a/drivers/cpufreq/cpufreq-nforce2.c
+++ b/drivers/cpufreq/cpufreq-nforce2.c
@@ -123,8 +123,6 @@  static void nforce2_write_pll(int pll)
 	/* Now write the value in all 64 registers */
 	for (temp = 0; temp <= 0x3f; temp++)
 		pci_write_config_dword(nforce2_dev, NFORCE2_PLLREG, pll);
-
-	return;
 }
 
 /**
@@ -438,4 +436,3 @@  static void __exit nforce2_exit(void)
 
 module_init(nforce2_init);
 module_exit(nforce2_exit);
-