| Message ID | 1544090279-26762-1-git-send-email-Christian.Hohnstaedt@wago.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tps65218.c: fix IRQ resource leak in tps65218_probe() | expand |
On Thu, 06 Dec 2018, Christian Hohnstaedt wrote: > Free allocated IRQ if reading the device ID fails. The patch is fine. However, in future please submit patches using the format set (by precedent) by the subsystem. I will fix the subject for you this time. To check the format, you can do: `git log --oneline -- <subsystem>` > Signed-off-by: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com> > --- > drivers/mfd/tps65218.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c > index 910f569..19270bc 100644 > --- a/drivers/mfd/tps65218.c > +++ b/drivers/mfd/tps65218.c > @@ -244,7 +244,7 @@ static int tps65218_probe(struct i2c_client *client, > ret = regmap_read(tps->regmap, TPS65218_REG_CHIPID, &chipid); > if (ret) { > dev_err(tps->dev, "Failed to read chipid: %d\n", ret); > - return ret; > + goto err_irq; > } > > tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
On Fri, 14 Dec 2018, Lee Jones wrote: > On Thu, 06 Dec 2018, Christian Hohnstaedt wrote: > > > Free allocated IRQ if reading the device ID fails. > > The patch is fine. However, in future please submit patches using the > format set (by precedent) by the subsystem. I will fix the subject > for you this time. > > To check the format, you can do: > > `git log --oneline -- <subsystem>` Patch applied, by the way.
On 12/14/2018 5:56 PM, Lee Jones wrote: > On Fri, 14 Dec 2018, Lee Jones wrote: > >> On Thu, 06 Dec 2018, Christian Hohnstaedt wrote: >> >>> Free allocated IRQ if reading the device ID fails. >> >> The patch is fine. However, in future please submit patches using the >> format set (by precedent) by the subsystem. I will fix the subject >> for you this time. >> >> To check the format, you can do: >> >> `git log --oneline -- <subsystem>` > > Patch applied, by the way. This would no longer be needed as the bigger clean up is here: https://lkml.org/lkml/2018/12/9/86 As both are applied it results in a compilation issue. Lee Jones, Do you want me to submit a fix patch? Or you can revert this patch? Anything fine by me. Let me know. Thanks, Keerthy >
On Mon, 17 Dec 2018, J, KEERTHY wrote: > > > On 12/14/2018 5:56 PM, Lee Jones wrote: > > On Fri, 14 Dec 2018, Lee Jones wrote: > > > > > On Thu, 06 Dec 2018, Christian Hohnstaedt wrote: > > > > > > > Free allocated IRQ if reading the device ID fails. > > > > > > The patch is fine. However, in future please submit patches using the > > > format set (by precedent) by the subsystem. I will fix the subject > > > for you this time. > > > > > > To check the format, you can do: > > > > > > `git log --oneline -- <subsystem>` > > > > Patch applied, by the way. > > This would no longer be needed as the bigger clean up is here: > > https://lkml.org/lkml/2018/12/9/86 > > As both are applied it results in a compilation issue. > > Lee Jones, > > Do you want me to submit a fix patch? Or you can revert this patch? > Anything fine by me. I have removed this patch from the MFD tree now. Thanks.
diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c index 910f569..19270bc 100644 --- a/drivers/mfd/tps65218.c +++ b/drivers/mfd/tps65218.c @@ -244,7 +244,7 @@ static int tps65218_probe(struct i2c_client *client, ret = regmap_read(tps->regmap, TPS65218_REG_CHIPID, &chipid); if (ret) { dev_err(tps->dev, "Failed to read chipid: %d\n", ret); - return ret; + goto err_irq; } tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
Free allocated IRQ if reading the device ID fails. Signed-off-by: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com> --- drivers/mfd/tps65218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)