[v13,15/25] kasan, mm: perform untagged pointers comparison in krealloc
diff mbox series

Message ID 14f6190d7846186a3506cd66d82446646fe65090.1544099024.git.andreyknvl@google.com
State Not Applicable, archived
Headers show
  • kasan: add software tag-based mode for arm64
Related show

Commit Message

Andrey Konovalov Dec. 6, 2018, 12:24 p.m. UTC
The krealloc function checks where the same buffer was reused or a new one
allocated by comparing kernel pointers. Tag-based KASAN changes memory tag
on the krealloc'ed chunk of memory and therefore also changes the pointer
tag of the returned pointer. Therefore we need to perform comparison on
untagged (with tags reset) pointers to check whether it's the same memory
region or not.

Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
 mm/slab_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 5f3504e26d4c..5aabcbd32d82 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1534,7 +1534,7 @@  void *krealloc(const void *p, size_t new_size, gfp_t flags)
 	ret = __do_krealloc(p, new_size, flags);
-	if (ret && p != ret)
+	if (ret && kasan_reset_tag(p) != kasan_reset_tag(ret))
 	return ret;