From patchwork Fri Dec 7 09:17:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 10717727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E1ABE17DB for ; Fri, 7 Dec 2018 09:19:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84119296BE for ; Fri, 7 Dec 2018 09:19:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 762B62E150; Fri, 7 Dec 2018 09:19:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C4BDF296BE for ; Fri, 7 Dec 2018 09:19:05 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 29F15267CFB; Fri, 7 Dec 2018 10:18:56 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 07B00267CFB; Fri, 7 Dec 2018 10:18:48 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by alsa0.perex.cz (Postfix) with ESMTP id A44F9267CC9 for ; Fri, 7 Dec 2018 10:18:45 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id w6so1459303pgl.6 for ; Fri, 07 Dec 2018 01:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KxPItma6iMq5b3ggI3ekPmiexyI65emc/TDmZwDFCZ4=; b=UM191/4+gK6D7CZdVa8mvHF1VSs+ECz5+aDJ1P0niaf+uB2QrWUV0evw/utj0FqjHq L/9VjPP1VNZNhN+XHH0JB11LxrxS2NVemS/uE8ybx7LdGr0sywUqhEk6sLMu449/b9IX vDXL0T1BwJ1LDvonEXrexZYOwXHQQHbivxfVRFZmdQZYBuTc2msTBppOthQQEg4PqEU5 Vpsvyhc5mBjBLQEWKuZ5+vYUCz+GpuZJRAv2L/F9GzG6OGKi3P9YhTi3gk9q8HsEFfsz JUdjAUYWwDxE7kHh/nUNagZOqxYWVjZrp04ZJRTAf3Po1XU3XVXUJwbixb6vMeueb2FE 43dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KxPItma6iMq5b3ggI3ekPmiexyI65emc/TDmZwDFCZ4=; b=Ykl/XXbLA6KDwkZB4ZmS/mlX3envivT1Qy8vncRlj/82Rx0CzcgkFfxGgSLDDk2DSL TU4gZZFPIdCX4TCB15Dt3Ahv6v24oE78yJ3Qqz7ExhXmakqfCXCYUPsw7Ilw7g/QUmWL jz4xd/hjoOaAx1v49JJjHKMmCZLzdl948Lv28QSrmA0ipYEEMAOaEeA5bBsJKV5yMw3z CokUJNzW37Bo+LrrnLgBnTsdYDxwlIPqBDi5hGQCVy3cEZluXEbwKDLA3N2RtbcJxxl2 oopxe/j1NcKMMkWzKTPaXumkJUPdKscAbkeOZ7esYNEbpU/Kk2z4dKSeJbvUQ/tst6Cc czdw== X-Gm-Message-State: AA+aEWar0GJvJ3u88i2QdC8Jd2h+JoM7ZhmAa5fuO0eJwnlD/2JGhQes xBeP6kngEQJe/KTuDJ1xHcQ+/g== X-Google-Smtp-Source: AFSGD/VwNQ+RpC8U2mbfnTTgNxblrALmYwcFQMIaAeu537DEwpiPc0oVUe0UHVhZkS7myCZfXpWigQ== X-Received: by 2002:a63:5a57:: with SMTP id k23mr1250327pgm.5.1544174324396; Fri, 07 Dec 2018 01:18:44 -0800 (PST) Received: from localhost.localdomain (125-227-158-176.HINET-IP.hinet.net. [125.227.158.176]) by smtp.gmail.com with ESMTPSA id y1sm3480927pfe.9.2018.12.07.01.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 01:18:44 -0800 (PST) From: Jian-Hong Pan To: Jaroslav Kysela , Takashi Iwai , Kailang Yang Date: Fri, 7 Dec 2018 17:17:12 +0800 Message-Id: <20181207091713.7483-3-jian-hong@endlessm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181207091713.7483-1-jian-hong@endlessm.com> References: <20181207091713.7483-1-jian-hong@endlessm.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, josh@wtmec.com, Hui Wang , Jian-Hong Pan , Daniel Drake , linux@endlessm.com Subject: [alsa-devel] [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The ASUS UX533FD with ALC294 cannot detect the headset MIC and outputs through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK and ALC294_FIXUP_ASUS_HEADSET_MIC quirk applied. Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- v2: - Modify the HDA verbs for UX333FA support - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC v3: - Modify the HDA verbs from Realtek's suggestion - Modify the quirk's entry name sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..aa7aabd6e09a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5518,6 +5518,8 @@ enum { ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, ALC294_FIXUP_ASUS_MIC, + ALC294_FIXUP_ASUS_HEADSET_MIC, + ALC294_FIXUP_ASUS_SPK, }; static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,26 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC }, + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, + [ALC294_FIXUP_ASUS_SPK] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Set EAPD high */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x8800 }, + { } + }, + .chained = true, + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6578,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),