diff mbox series

[v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices

Message ID 20181208014724.951-3-kdgwill@google.com (mailing list archive)
State New, archived
Headers show
Series Disable LPM by matching interface | expand

Commit Message

Kyle Williams Dec. 8, 2018, 1:47 a.m. UTC 
From: Kyle Williams <kdgwill@chromium.org>

Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of certain Logitech uvc devices and other powered media
devices such causes 'not enough bandwidth for new device state' error.

This patch enables the USB_QUIRK_NO_LPM quirk entries for all connected
Logitech UVC devices indicating LPM should remain disabled for the device.

Signed-off-by: Kyle Williams <kdgwill@chromium.org>
---
 drivers/usb/core/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Dec. 12, 2018, 11:37 a.m. UTC | #1 
On Fri, Dec 07, 2018 at 08:47:22PM -0500, Kyle Williams wrote:
> From: Kyle Williams <kdgwill@chromium.org>
> 
> Description: Some USB device / host controller combinations seem to have
> problems with Link Power management. In particular it is described that
> the combination of certain Logitech uvc devices and other powered media
> devices such causes 'not enough bandwidth for new device state' error.

Same thing with "Description:" :(
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0690fcff0ea2..bbbb7e6df958 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -440,7 +440,7 @@  static const struct usb_device_id usb_quirk_list[] = {
 static const struct usb_device_id usb_interface_quirk_list[] = {
 	/* Logitech UVC Cameras */
 	{ USB_VENDOR_AND_INTERFACE_INFO(0x046d, USB_CLASS_VIDEO, 1, 0),
-	  .driver_info = USB_QUIRK_RESET_RESUME },
+	  .driver_info = USB_QUIRK_RESET_RESUME | USB_QUIRK_NO_LPM },
 
 	{ }  /* terminating entry must be last */
 };