selftests/vm/gup_benchmark.c: match gup struct to kernel
diff mbox series

Message ID 20181208020645.GA28467@alison-desk.jf.intel.com
State Mainlined
Commit 91cd63d320f84dcbf21d4327f31f7e1f85adebd0
Headers show
Series
  • selftests/vm/gup_benchmark.c: match gup struct to kernel
Related show

Commit Message

Alison Schofield Dec. 8, 2018, 2:06 a.m. UTC
An expansion field was added to the kernel copy of this structure for
future use. See mm/gup_benchmark.c.

Add the same expansion field here, so that the IOCTL command decodes
correctly. Otherwise, it fails with EINVAL.

Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
 tools/testing/selftests/vm/gup_benchmark.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kirill A. Shutemov Dec. 10, 2018, 1:30 p.m. UTC | #1
On Fri, Dec 07, 2018 at 06:06:45PM -0800, Alison Schofield wrote:
> An expansion field was added to the kernel copy of this structure for
> future use. See mm/gup_benchmark.c.
> 
> Add the same expansion field here, so that the IOCTL command decodes
> correctly. Otherwise, it fails with EINVAL.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Alison Schofield Jan. 15, 2019, 5:45 p.m. UTC | #2
Hi Shauh,

Ping on this one. It has Kirill's ACK. Without this fix the
gup_benchmark fails to run (at all).

Thanks!
Alison

On Fri, Dec 07, 2018 at 06:06:45PM -0800, Alison Schofield wrote:
> An expansion field was added to the kernel copy of this structure for
> future use. See mm/gup_benchmark.c.
> 
> Add the same expansion field here, so that the IOCTL command decodes
> correctly. Otherwise, it fails with EINVAL.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

> ---
>  tools/testing/selftests/vm/gup_benchmark.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/selftests/vm/gup_benchmark.c
> index 880b96fc80d4..c0534e298b51 100644
> --- a/tools/testing/selftests/vm/gup_benchmark.c
> +++ b/tools/testing/selftests/vm/gup_benchmark.c
> @@ -25,6 +25,7 @@ struct gup_benchmark {
>  	__u64 size;
>  	__u32 nr_pages_per_call;
>  	__u32 flags;
> +	__u64 expansion[10];	/* For future use */
>  };
>  
>  int main(int argc, char **argv)
> -- 
> 2.14.1
>
shuah Jan. 15, 2019, 8:46 p.m. UTC | #3
On 1/15/19 10:45 AM, Alison Schofield wrote:
> Hi Shauh,
> 
> Ping on this one. It has Kirill's ACK. Without this fix the
> gup_benchmark fails to run (at all).
> 
> Thanks!
> Alison
> 
> On Fri, Dec 07, 2018 at 06:06:45PM -0800, Alison Schofield wrote:
>> An expansion field was added to the kernel copy of this structure for
>> future use. See mm/gup_benchmark.c.
>>
>> Add the same expansion field here, so that the IOCTL command decodes
>> correctly. Otherwise, it fails with EINVAL.
>>
>> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 

Sorry for the delay and thanks for the ping. I will apply this for
linux-kselftest fixes for 5.0-rc3

thanks,
-- Shuah

Patch
diff mbox series

diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/selftests/vm/gup_benchmark.c
index 880b96fc80d4..c0534e298b51 100644
--- a/tools/testing/selftests/vm/gup_benchmark.c
+++ b/tools/testing/selftests/vm/gup_benchmark.c
@@ -25,6 +25,7 @@  struct gup_benchmark {
 	__u64 size;
 	__u32 nr_pages_per_call;
 	__u32 flags;
+	__u64 expansion[10];	/* For future use */
 };
 
 int main(int argc, char **argv)