From patchwork Sun Dec 9 05:19:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 10719825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B00513AF for ; Sun, 9 Dec 2018 05:19:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41BDE2A872 for ; Sun, 9 Dec 2018 05:19:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 35A952A954; Sun, 9 Dec 2018 05:19:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C61272A872 for ; Sun, 9 Dec 2018 05:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbeLIFTE (ORCPT ); Sun, 9 Dec 2018 00:19:04 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39292 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbeLIFTD (ORCPT ); Sun, 9 Dec 2018 00:19:03 -0500 Received: by mail-pl1-f194.google.com with SMTP id 101so3676906pld.6; Sat, 08 Dec 2018 21:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uCPeexdJ5AfMKP2nzbz+gP5I2yOBaGAIYFi/XL/QO7M=; b=sKQk2ahQPuOk36dz0Jz9S7nwtD97Fqtor0POPxWSr1VR+pN9LD13l1jwZ+EMIhhXO3 BlGtAkH5AMPfcn2ZfeszTgBlR7mQV6BMaHinjjg8UkYqqgalCATwd2T0BLokUuKS9cIb z0ZjYb5JdHEMdG01AjxJyotkojx4iwDHlSrVt7bXlX/STb2CwN5ZmyaApQlYO6CFEE9b CVwTVFbO5cPk9n9FJO1ZHgIhKTaMzZKHeisnxiofZ2hvP+No/HIQw1QPp//UA2pXW5lY N8+pVUENOb8vJalymdG1tqrhuyXdlrDZFsybY3ZHdpL3TNAT19r9sr6ZezJsJDJi0kjL T9Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uCPeexdJ5AfMKP2nzbz+gP5I2yOBaGAIYFi/XL/QO7M=; b=rGL3g95aRhUHCuz3x/dt4Z9Imim63nUHVXdh8nv4tv96IrVTig2s5h1veWR59eZDYy tH++U/wba4PVK1wVdqJvBUN1IpOEohrh5C4Zh44BAbPYZONSggEswxg1W8IUBEKRu1t1 esOQmo2qbA34H3kbg/DseVxYe+RT/c/qO6cC2mAMMjp3W4N9ABJ31fkrhtC8kuVaaPA/ w4CuYwrpnWPOz14Ft3VrVn3R5FJS/r0821SmO5P3J+Fv9km8d7j67oKGbTsBJTg3eeq4 IVvhFsFkJMJS3B/ug9NX8Y+VcOCj1Pi4tUTfLJG/CTSUV4QLuuQLGF1IiCdZmBwGIurx dqrg== X-Gm-Message-State: AA+aEWaXKUETaxLqhFUgwtI29hfjCQbQVTwV8/AFIlzD9lS5Mlt4+yDF KBYwSAOp6kKczjuPlhhG85U= X-Google-Smtp-Source: AFSGD/XdZHUg09GAKXVsVDv0T9PM2gm87S4j2GLVIz6IYw2IXMT/T2zUCPfDrd9VH8vi+DO5A9Takg== X-Received: by 2002:a17:902:5ac7:: with SMTP id g7mr7879955plm.212.1544332743252; Sat, 08 Dec 2018 21:19:03 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id n66sm11913025pfk.19.2018.12.08.21.19.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 08 Dec 2018 21:19:02 -0800 (PST) From: Yangtao Li To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH v2] Input: i8042 fix refcount leak Date: Sun, 9 Dec 2018 00:19:00 -0500 Message-Id: <20181209051900.19035-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/input/serio/i8042-sparcio.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index 796289846204..cc6777b4c4ea 100644 --- a/drivers/input/serio/i8042-sparcio.h +++ b/drivers/input/serio/i8042-sparcio.h @@ -111,13 +111,17 @@ static int __init i8042_platform_init(void) struct device_node *root = of_find_node_by_path("/"); if (!strcmp(root->name, "SUNW,JavaStation-1")) { + of_node_put(root); /* Hardcoded values for MrCoffee. */ i8042_kbd_irq = i8042_aux_irq = 13 | 0x20; kbd_iobase = ioremap(0x71300060, 8); if (!kbd_iobase) return -ENODEV; } else { - int err = platform_driver_register(&sparc_i8042_driver); + int err; + + of_node_put(root); + err = platform_driver_register(&sparc_i8042_driver); if (err) return err;