From patchwork Mon Dec 10 10:03:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10720977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0EF36C5 for ; Mon, 10 Dec 2018 10:04:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFC1129C24 for ; Mon, 10 Dec 2018 10:04:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C3EBD29D4F; Mon, 10 Dec 2018 10:04:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 87CC329C24 for ; Mon, 10 Dec 2018 10:04:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EF4F6E399; Mon, 10 Dec 2018 10:04:08 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99DA76E395 for ; Mon, 10 Dec 2018 10:04:07 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id p6so8967603eds.0 for ; Mon, 10 Dec 2018 02:04:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yWLFgSsEumH0JHD5DJODVmD64YdBCrl6TKALFjsLTME=; b=lDd8H3WbOJmjnzVYq/T4L4OcS1mb5Nr+wdW5ZZZdr/p4dZQKcGNtk2u8EXZZSTC2En vKgVm7Lj4N9tp8FaAfYDzwhcqh3aBTBTZsN9eVjqLFEwUE1U3w1qk8Dq+diyuIiwWuDe pxAuSmCAz529PeraiqHT8p1kkWlOGiCY9K8AZaNIQqv4odLfPYWPoD+47AbtqRkCwCLl KcbtdMmdigZqKx4Amg7Y/3Io87ryF5hKfRxZ5jSF7jDzeYuxnu9He6+lgKGJM7ilXXDV GolXz2hsjDfxRwNUJ9n9dM4YjhSkc0TXjqQi2k5X3nR0wVNVGeBt3Frl6tpcuaSqsydn zEYg== X-Gm-Message-State: AA+aEWbqDrVWRffFlwpQUmrMi3qsiM8BH/auxQwhMBTt/DCaFzL3Ybgb Y1PsJyjXgE4uKkLdg4RRYu+JhyQFths= X-Google-Smtp-Source: AFSGD/VbyLLOnxFhkEJk4xz9hM78/fk2vaVd1RZDqhZTZwHw1vAz/1Utp696O1GcIk5zmX7NNXycZg== X-Received: by 2002:a50:fb03:: with SMTP id d3mr10605116edq.183.1544436245887; Mon, 10 Dec 2018 02:04:05 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id c11-v6sm1720942ejz.70.2018.12.10.02.04.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 02:04:05 -0800 (PST) From: Daniel Vetter To: Intel Graphics Development Date: Mon, 10 Dec 2018 11:03:53 +0100 Message-Id: <20181210100359.22507-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.0.rc1 In-Reply-To: <20181210100359.22507-1-daniel.vetter@ffwll.ch> References: <20181210100359.22507-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/7] drm/ch7006: Stop using drm_crtc_force_disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , DRI Development , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The correct way for legacy drivers to update properties that need to do a full modeset, is to do a full modeset. Note that we don't need to call the drm_mode_config_internal helper because we're not changing any of the refcounted paramters. Signed-off-by: Daniel Vetter Cc: Daniel Vetter --- drivers/gpu/drm/i2c/ch7006_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index 544a8a2d3562..719c79d3fac9 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -359,10 +359,10 @@ static int ch7006_encoder_set_property(struct drm_encoder *encoder, if (modes_changed) { drm_helper_probe_single_connector_modes(connector, 0, 0); - /* Disable the crtc to ensure a full modeset is - * performed whenever it's turned on again. */ if (crtc) - drm_crtc_force_disable(crtc); + return drm_crtc_helper_set_mode(crtc, &crtc->mode, + crtc->x, crtc->y, + crtc->primary->fb); } return 0;