[6/7] drm/xen: Don't set the dpms hook
diff mbox series

Message ID 20181210100359.22507-7-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • legacy helper cleanup
Related show

Commit Message

Daniel Vetter Dec. 10, 2018, 10:03 a.m. UTC
Doesn't do anything for atomic.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Cc: xen-devel@lists.xen.org
---
 drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Oleksandr Andrushchenko Dec. 10, 2018, 10:12 a.m. UTC | #1
On 12/10/18 12:03 PM, Daniel Vetter wrote:
> Doesn't do anything for atomic.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Cc: xen-devel@lists.xen.org
> ---
>   drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.c b/drivers/gpu/drm/xen/xen_drm_front_conn.c
> index c91ae532fa55..54af2669b1b3 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_conn.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.c
> @@ -89,7 +89,6 @@ static const struct drm_connector_helper_funcs connector_helper_funcs = {
>   };
>   
>   static const struct drm_connector_funcs connector_funcs = {
> -	.dpms = drm_helper_connector_dpms,
>   	.fill_modes = drm_helper_probe_single_connector_modes,
>   	.destroy = drm_connector_cleanup,
>   	.reset = drm_atomic_helper_connector_reset,

Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Thank you,

Oleksandr
Daniel Vetter Dec. 12, 2018, 10:56 a.m. UTC | #2
On Mon, Dec 10, 2018 at 12:12:05PM +0200, Oleksandr Andrushchenko wrote:
> On 12/10/18 12:03 PM, Daniel Vetter wrote:
> > Doesn't do anything for atomic.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > Cc: xen-devel@lists.xen.org
> > ---
> >   drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.c b/drivers/gpu/drm/xen/xen_drm_front_conn.c
> > index c91ae532fa55..54af2669b1b3 100644
> > --- a/drivers/gpu/drm/xen/xen_drm_front_conn.c
> > +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.c
> > @@ -89,7 +89,6 @@ static const struct drm_connector_helper_funcs connector_helper_funcs = {
> >   };
> >   static const struct drm_connector_funcs connector_funcs = {
> > -	.dpms = drm_helper_connector_dpms,
> >   	.fill_modes = drm_helper_probe_single_connector_modes,
> >   	.destroy = drm_connector_cleanup,
> >   	.reset = drm_atomic_helper_connector_reset,
> 
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

This and the previous patch merged, thanks for reviewing.
-Daniel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.c b/drivers/gpu/drm/xen/xen_drm_front_conn.c
index c91ae532fa55..54af2669b1b3 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_conn.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_conn.c
@@ -89,7 +89,6 @@  static const struct drm_connector_helper_funcs connector_helper_funcs = {
 };
 
 static const struct drm_connector_funcs connector_funcs = {
-	.dpms = drm_helper_connector_dpms,
 	.fill_modes = drm_helper_probe_single_connector_modes,
 	.destroy = drm_connector_cleanup,
 	.reset = drm_atomic_helper_connector_reset,