diff mbox series

[2/2] ARM: defconfig: Switch LPC18xx to use PL11x DRM driver

Message ID 20181210101620.418-2-linus.walleij@linaro.org (mailing list archive)
State New, archived
Headers show
Series [1/2] ARM: defconfig: Update LPC18xx defconfig | expand

Commit Message

Linus Walleij Dec. 10, 2018, 10:16 a.m. UTC
None of the LPC18xx device trees contains any display settings,
it just defines a device tree node for the CLCD (PL11x) set
as "disabled" and no panels are attached on any device tree.

This I conclude that the hardware is dormant on existing
systems, so we can without any problems switch the defconfig
over from the old ARMCLCD frame buffer driver to the new
PL11x DRM driver.

Cc: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/configs/lpc18xx_defconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Vladimir Zapolskiy Dec. 10, 2018, 11:23 a.m. UTC | #1
Hi Linus,

On 12/10/2018 12:16 PM, Linus Walleij wrote:
> None of the LPC18xx device trees contains any display settings,
> it just defines a device tree node for the CLCD (PL11x) set
> as "disabled" and no panels are attached on any device tree.
> 
> This I conclude that the hardware is dormant on existing
> systems, so we can without any problems switch the defconfig
> over from the old ARMCLCD frame buffer driver to the new
> PL11x DRM driver.
> 

Correct.

FWIW I've tested DRM PL111 driver on my board, if you are interested
the pending DT patch is https://patchwork.kernel.org/patch/10636591/

Thank you for the changes, I'll review and collect them for v4.22.

--
Best wishes,
Vladimir
Linus Walleij Dec. 10, 2018, 11:37 a.m. UTC | #2
On Mon, Dec 10, 2018 at 12:23 PM Vladimir Zapolskiy <vz@mleia.com> wrote:

> FWIW I've tested DRM PL111 driver on my board, if you are interested
> the pending DT patch is https://patchwork.kernel.org/patch/10636591/

Looks good.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> Thank you for the changes, I'll review and collect them for v4.22.

OK feel free to use however you like or use your own patches,
all I really want is the PL11x DRM driver to become default
for all platforms using PL11x.

Will send LPC32xx patches next. Same thing there, use it
if you like, all I worry about is the end result :)

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/arch/arm/configs/lpc18xx_defconfig b/arch/arm/configs/lpc18xx_defconfig
index 3627495b3dd0..1b72a1af8d54 100644
--- a/arch/arm/configs/lpc18xx_defconfig
+++ b/arch/arm/configs/lpc18xx_defconfig
@@ -117,8 +117,10 @@  CONFIG_WATCHDOG=y
 CONFIG_LPC18XX_WATCHDOG=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
-CONFIG_FB=y
-CONFIG_FB_ARMCLCD=y
+CONFIG_DRM=y
+CONFIG_DRM_PL111=y
+CONFIG_FB_MODE_HELPERS=y
+CONFIG_BACKLIGHT_LCD_SUPPORT=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_ROOT_HUB_TT=y