diff mbox series

[1/4] ARM: omap2: avoid section mismatch warning

Message ID 20181210215856.2238253-1-arnd@arndb.de (mailing list archive)
State New, archived
Headers show
Series [1/4] ARM: omap2: avoid section mismatch warning | expand

Commit Message

Arnd Bergmann Dec. 10, 2018, 9:58 p.m. UTC
WARNING: vmlinux.o(.text+0x27530): Section mismatch in reference from the function am43xx_suspend_init() to the function .init.text:am43xx_map_scu()
The function am43xx_suspend_init() references
the function __init am43xx_map_scu().
This is often because am43xx_suspend_init lacks a __init
annotation or the annotation of am43xx_map_scu is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-omap2/pm33xx-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren Dec. 10, 2018, 10:09 p.m. UTC | #1
* Arnd Bergmann <arnd@arndb.de> [181210 21:59]:
> WARNING: vmlinux.o(.text+0x27530): Section mismatch in reference from the function am43xx_suspend_init() to the function .init.text:am43xx_map_scu()
> The function am43xx_suspend_init() references
> the function __init am43xx_map_scu().
> This is often because am43xx_suspend_init lacks a __init
> annotation or the annotation of am43xx_map_scu is wrong.

Acked-by: Tony Lindgren <tony@atomide.com>
Santosh Shilimkar Dec. 11, 2018, 2:11 a.m. UTC | #2
On 12/10/2018 1:58 PM, Arnd Bergmann wrote:
> WARNING: vmlinux.o(.text+0x27530): Section mismatch in reference from the function am43xx_suspend_init() to the function .init.text:am43xx_map_scu()
> The function am43xx_suspend_init() references
> the function __init am43xx_map_scu().
> This is often because am43xx_suspend_init lacks a __init
> annotation or the annotation of am43xx_map_scu is wrong.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Kevin Hilman Dec. 11, 2018, 6:12 p.m. UTC | #3
Arnd Bergmann <arnd@arndb.de> writes:

> WARNING: vmlinux.o(.text+0x27530): Section mismatch in reference from the function am43xx_suspend_init() to the function .init.text:am43xx_map_scu()
> The function am43xx_suspend_init() references
> the function __init am43xx_map_scu().
> This is often because am43xx_suspend_init lacks a __init
> annotation or the annotation of am43xx_map_scu is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Olof Johansson Dec. 12, 2018, 10:05 p.m. UTC | #4
On Mon, Dec 10, 2018 at 02:09:26PM -0800, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [181210 21:59]:
> > WARNING: vmlinux.o(.text+0x27530): Section mismatch in reference from the function am43xx_suspend_init() to the function .init.text:am43xx_map_scu()
> > The function am43xx_suspend_init() references
> > the function __init am43xx_map_scu().
> > This is often because am43xx_suspend_init lacks a __init
> > annotation or the annotation of am43xx_map_scu is wrong.
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Applied, thanks!


-Olof
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index f4971e4a86b2..724cf5774a6c 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -28,7 +28,7 @@  static struct clockdomain *gfx_l4ls_clkdm;
 static void __iomem *scu_base;
 static struct omap_hwmod *rtc_oh;
 
-static int __init am43xx_map_scu(void)
+static int am43xx_map_scu(void)
 {
 	scu_base = ioremap(scu_a9_get_base(), SZ_256);