| Message ID | 20181210223133.22667-1-ndesaulniers@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: VDSO: Drop implicit common-page-size linker flag | expand |
On Mon, Dec 10, 2018 at 2:32 PM <ndesaulniers@google.com> wrote: > > GNU linker's -z common-page-size's default value is based on the target > architecture. arch/arm/vdso/Makefile sets it to the architecture > default, which is implicit and redundant. Drop it. > > Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/arm/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index f4efff9d3afb..8f2fac5acbc8 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -11,7 +11,7 @@ ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector > ccflags-y += -DDISABLE_BRANCH_PROFILING > > VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > +VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 > VDSO_LDFLAGS += -nostdlib -shared > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id) > -- > 2.20.0.rc2.403.gdbc3b29805-goog > Bumping for review. This option has been removed from all other architectures.
On Mon, Dec 10, 2018 at 11:32 PM <ndesaulniers@google.com> wrote: > > GNU linker's -z common-page-size's default value is based on the target > architecture. arch/arm/vdso/Makefile sets it to the architecture > default, which is implicit and redundant. Drop it. > > Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- The patch looks good to me, Acked-by: Arnd Bergmann <arnd@arndb.de> Adding Nathan Lynch to Cc though for further comments, he originally added the Makefile flags here and might still remember why he did it. Unless Nathan objects, please add the patch to Russell's patch tracker. > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index f4efff9d3afb..8f2fac5acbc8 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -11,7 +11,7 @@ ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector > ccflags-y += -DDISABLE_BRANCH_PROFILING > > VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > +VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 > VDSO_LDFLAGS += -nostdlib -shared > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id) > -- > 2.20.0.rc2.403.gdbc3b29805-goog > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes: > On Mon, Dec 10, 2018 at 11:32 PM <ndesaulniers@google.com> wrote: >> >> GNU linker's -z common-page-size's default value is based on the target >> architecture. arch/arm/vdso/Makefile sets it to the architecture >> default, which is implicit and redundant. Drop it. >> >> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com >> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> >> --- > > The patch looks good to me, > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Adding Nathan Lynch to Cc though for further comments, he originally > added the Makefile flags here and might still remember why he did it. > > Unless Nathan objects, please add the patch to Russell's patch > tracker. Thanks for cc'ing me -- no objection. Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
On Wed, Apr 24, 2019 at 6:45 AM Nathan Lynch <nathanl@linux.ibm.com> wrote: > Arnd Bergmann <arnd@arndb.de> writes: > > Acked-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Nathan Lynch <nathanl@linux.ibm.com> https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8859/1
diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index f4efff9d3afb..8f2fac5acbc8 100644 --- a/arch/arm/vdso/Makefile +++ b/arch/arm/vdso/Makefile @@ -11,7 +11,7 @@ ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector ccflags-y += -DDISABLE_BRANCH_PROFILING VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 +VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 VDSO_LDFLAGS += -nostdlib -shared VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id)
GNU linker's -z common-page-size's default value is based on the target architecture. arch/arm/vdso/Makefile sets it to the architecture default, which is implicit and redundant. Drop it. Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/arm/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)