diff mbox series

arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii

Message ID 20181212104552.27414-1-horms+renesas@verge.net.au (mailing list archive)
State New, archived
Headers show
Series arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii | expand

Commit Message

Simon Horman Dec. 12, 2018, 10:45 a.m. UTC
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
August 24, 2018, the TX clock internal delay mode doesn't support
on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on renesas-devel-20181210-v4.20-rc6

Comments

Biju Das Dec. 13, 2018, 10:08 a.m. UTC | #1
Hi Simon,

Thanks for the  patch.

> Subject: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy
> mode to rgmii
>
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of August
> 24, 2018, the TX clock internal delay mode doesn't support on R-Car E3. This
> patch fixes EthernetAVB phy mode to rgmii.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>  Based on renesas-devel-20181210-v4.20-rc6
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddcbbae7..0c4df048a8cb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -248,7 +248,7 @@
>  pinctrl-names = "default";
>  renesas,no-ether-link;
>  phy-handle = <&phy0>;
> -phy-mode = "rgmii-txid";
> +phy-mode = "rgmii";

The default value of phy-mode in 777990 SoC dtsi is "rgmii". So we don't need to redefine this in board dtsi, I think.

Regards,
Biju


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddcbbae7..0c4df048a8cb 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -248,7 +248,7 @@ 
 	pinctrl-names = "default";
 	renesas,no-ether-link;
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii";
 	status = "okay";
 
 	phy0: ethernet-phy@0 {