ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M
diff mbox series

Message ID 1544647253-3806-1-git-send-email-festevam@gmail.com
State New
Headers show
Series
  • ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M
Related show

Commit Message

Fabio Estevam Dec. 12, 2018, 8:40 p.m. UTC
eukrea-tlv320.c machine driver runs on non-DT platforms
and include <asm/mach-types.h> header file in order to be able
to use some machine_is_eukrea_xxx() macros.

Since commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
the ARCH_MXC symbol is visible on ARM64 too.

Building it for ARM64 causes the following build error:

sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory

Avoid this error by not allowing to build the SND_SOC_EUKREA_TLV320
driver when ARM64 is selected.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi Mark,

Commit commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
is present in Shawn's tree, so maybe this should be taken by Shawn?

 sound/soc/fsl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo Dec. 13, 2018, 1:55 a.m. UTC | #1
On Wed, Dec 12, 2018 at 06:40:53PM -0200, Fabio Estevam wrote:
> eukrea-tlv320.c machine driver runs on non-DT platforms
> and include <asm/mach-types.h> header file in order to be able
> to use some machine_is_eukrea_xxx() macros.
> 
> Since commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
> the ARCH_MXC symbol is visible on ARM64 too.
> 
> Building it for ARM64 causes the following build error:
> 
> sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory
> 
> Avoid this error by not allowing to build the SND_SOC_EUKREA_TLV320
> driver when ARM64 is selected.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Mark,
> 
> Commit commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
> is present in Shawn's tree, so maybe this should be taken by Shawn?

I would suggest you drop the mentioning of the commit from your commit
log, so that Mark can take the patch as a preparation for i.MX8 landing.

Shawn

> 
>  sound/soc/fsl/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 6ec19fb..2e75b5b 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -221,7 +221,7 @@ config SND_SOC_PHYCORE_AC97
>  
>  config SND_SOC_EUKREA_TLV320
>  	tristate "Eukrea TLV320"
> -	depends on ARCH_MXC && I2C
> +	depends on ARCH_MXC && !ARM64 && I2C
>  	select SND_SOC_TLV320AIC23_I2C
>  	select SND_SOC_IMX_AUDMUX
>  	select SND_SOC_IMX_SSI
> -- 
> 2.7.4
>
Fabio Estevam Dec. 13, 2018, 2:09 a.m. UTC | #2
Hi Shawn,

On Wed, Dec 12, 2018 at 11:56 PM Shawn Guo <shawnguo@kernel.org> wrote:

> I would suggest you drop the mentioning of the commit from your commit
> log, so that Mark can take the patch as a preparation for i.MX8 landing.

Thanks for your suggestion. I did it in v2.
Mark Brown Dec. 13, 2018, 11 a.m. UTC | #3
On Wed, Dec 12, 2018 at 06:40:53PM -0200, Fabio Estevam wrote:
> eukrea-tlv320.c machine driver runs on non-DT platforms
> and include <asm/mach-types.h> header file in order to be able
> to use some machine_is_eukrea_xxx() macros.

Oh, I actually just did this myself as a -next build report was earlier
on in my inbox.  I'll drop it and apply your v2 patch instead since I
didn't push out my change yet.

Patch
diff mbox series

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 6ec19fb..2e75b5b 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -221,7 +221,7 @@  config SND_SOC_PHYCORE_AC97
 
 config SND_SOC_EUKREA_TLV320
 	tristate "Eukrea TLV320"
-	depends on ARCH_MXC && I2C
+	depends on ARCH_MXC && !ARM64 && I2C
 	select SND_SOC_TLV320AIC23_I2C
 	select SND_SOC_IMX_AUDMUX
 	select SND_SOC_IMX_SSI