diff mbox series

[v2] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii

Message ID 20181214155844.25662-1-horms+renesas@verge.net.au (mailing list archive)
State Mainlined, archived
Commit 7eda14afb8843a0d5b6120b889ec8eec407b214d
Headers show
Series [v2] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii | expand

Commit Message

Simon Horman Dec. 14, 2018, 3:58 p.m. UTC
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
August 24, 2018, the TX clock internal delay mode doesn't support
on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.

v2 [Simon Horman]
* Simply drop phy-mode property from r8a77990-ebisu.dts
  as the default property for this for r8a77990, as set in
  r8a77990.dtsi, is "rgmii".

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 -
 1 file changed, 1 deletion(-)

 Based on renesas-devel-20181213-v4.20-rc6

Comments

Ulrich Hecht Dec. 18, 2018, 9:25 a.m. UTC | #1
> On December 14, 2018 at 4:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> 
> 
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> 
> According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> August 24, 2018, the TX clock internal delay mode doesn't support
> on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.
> 
> v2 [Simon Horman]
> * Simply drop phy-mode property from r8a77990-ebisu.dts
>   as the default property for this for r8a77990, as set in
>   r8a77990.dtsi, is "rgmii".
> 
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
>  Based on renesas-devel-20181213-v4.20-rc6
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddcbbae7..b7082c5bab60 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -248,7 +248,6 @@
>  	pinctrl-names = "default";
>  	renesas,no-ether-link;
>  	phy-handle = <&phy0>;
> -	phy-mode = "rgmii-txid";
>  	status = "okay";
>  
>  	phy0: ethernet-phy@0 {
> -- 
> 2.11.0
>

Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>

CU
Uli
Simon Horman Dec. 18, 2018, 10:28 a.m. UTC | #2
On Tue, Dec 18, 2018 at 10:25:09AM +0100, Ulrich Hecht wrote:
> 
> > On December 14, 2018 at 4:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > 
> > 
> > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > 
> > According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> > August 24, 2018, the TX clock internal delay mode doesn't support
> > on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.
> > 
> > v2 [Simon Horman]
> > * Simply drop phy-mode property from r8a77990-ebisu.dts
> >   as the default property for this for r8a77990, as set in
> >   r8a77990.dtsi, is "rgmii".
> > 
> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> >  Based on renesas-devel-20181213-v4.20-rc6
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > index 62bdddcbbae7..b7082c5bab60 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > @@ -248,7 +248,6 @@
> >  	pinctrl-names = "default";
> >  	renesas,no-ether-link;
> >  	phy-handle = <&phy0>;
> > -	phy-mode = "rgmii-txid";
> >  	status = "okay";
> >  
> >  	phy0: ethernet-phy@0 {
> > -- 
> > 2.11.0
> >
> 
> Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>

Thanks, applied for v4.22.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddcbbae7..b7082c5bab60 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -248,7 +248,6 @@ 
 	pinctrl-names = "default";
 	renesas,no-ether-link;
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii-txid";
 	status = "okay";
 
 	phy0: ethernet-phy@0 {