| Message ID | 20181215163329.4710-1-grawity@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Input: synaptics - enable SMBus for HP EliteBook 840 G4 | expand |
On Sat, Dec 15, 2018 at 5:34 PM Mantas Mikulėnas <grawity@gmail.com> wrote: > > dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13) > says it can support a different bus." > > I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and > 4.19.x and it seems to work well. No problems seen with suspend/resume. > > Also, it appears that RMI/SMBus mode is actually required for 3-4 finger > multitouch gestures to work -- otherwise they are not reported at all. > > Information from dmesg in both modes: > > psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, > caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742 > > psmouse serio3: synaptics: Trying to set up SMBus access > rmi4_smbus 6-002c: registering SMbus-connected sensor > rmi4_f01 rmi4-00.fn01: found RMI device, > manufacturer: Synaptics, product: TM3139-001, fw id: 2000742 > > Signed-off-by: Mantas Mikulėnas <grawity@gmail.com> > --- Thanks for the test and the patch: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 2bd5bb11c8ba..0b5c88609e1f 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -178,6 +178,7 @@ static const char * const smbus_pnp_ids[] = { > "LEN0096", /* X280 */ > "LEN0097", /* X280 -> ALPS trackpoint */ > "LEN200f", /* T450s */ > + "SYN3052", /* HP EliteBook 840 G4 */ > "SYN3221", /* HP 15-ay000 */ > NULL > }; > -- > 2.20.0 >
On Mon, Dec 17, 2018 at 09:16:15AM +0100, Benjamin Tissoires wrote: > On Sat, Dec 15, 2018 at 5:34 PM Mantas Mikulėnas <grawity@gmail.com> wrote: > > > > dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13) > > says it can support a different bus." > > > > I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and > > 4.19.x and it seems to work well. No problems seen with suspend/resume. > > > > Also, it appears that RMI/SMBus mode is actually required for 3-4 finger > > multitouch gestures to work -- otherwise they are not reported at all. > > > > Information from dmesg in both modes: > > > > psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, > > caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742 > > > > psmouse serio3: synaptics: Trying to set up SMBus access > > rmi4_smbus 6-002c: registering SMbus-connected sensor > > rmi4_f01 rmi4-00.fn01: found RMI device, > > manufacturer: Synaptics, product: TM3139-001, fw id: 2000742 > > > > Signed-off-by: Mantas Mikulėnas <grawity@gmail.com> > > --- > > Thanks for the test and the patch: > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Applied, thank you. > > Cheers, > Benjamin > > > drivers/input/mouse/synaptics.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > index 2bd5bb11c8ba..0b5c88609e1f 100644 > > --- a/drivers/input/mouse/synaptics.c > > +++ b/drivers/input/mouse/synaptics.c > > @@ -178,6 +178,7 @@ static const char * const smbus_pnp_ids[] = { > > "LEN0096", /* X280 */ > > "LEN0097", /* X280 -> ALPS trackpoint */ > > "LEN200f", /* T450s */ > > + "SYN3052", /* HP EliteBook 840 G4 */ > > "SYN3221", /* HP 15-ay000 */ > > NULL > > }; > > -- > > 2.20.0 > >
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 2bd5bb11c8ba..0b5c88609e1f 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -178,6 +178,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ "LEN200f", /* T450s */ + "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */ NULL };
dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13) says it can support a different bus." I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and 4.19.x and it seems to work well. No problems seen with suspend/resume. Also, it appears that RMI/SMBus mode is actually required for 3-4 finger multitouch gestures to work -- otherwise they are not reported at all. Information from dmesg in both modes: psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742 psmouse serio3: synaptics: Trying to set up SMBus access rmi4_smbus 6-002c: registering SMbus-connected sensor rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3139-001, fw id: 2000742 Signed-off-by: Mantas Mikulėnas <grawity@gmail.com> --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+)