| Message ID | 20181217014333.75969-1-efimochkin.sv@phystech.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging:iio:adc: fix codestyle | expand |
The patch prefix should be "staging: iio: adc: ad7280a:". Do git log --oneline drivers/staging/iio/adc/ad7280a.c and copy what other people do. On Mon, Dec 17, 2018 at 04:43:33AM +0300, Sergey Efimochkin wrote: > staging:iio:adc: fix codestyle Only to do one thing per patch. We need a better patch description. > Signed-off-by: Sergey Efimochkin <efimochkin.sv@phystech.edu> > --- > drivers/staging/iio/adc/ad7280a.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > index 58420dcb406d..52e12d1201b3 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -706,8 +706,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) > st->cell_threshhigh) > iio_push_event(indio_dev, > IIO_EVENT_CODE(IIO_VOLTAGE, > - 1, > - 0, > + 1, > + 0, > IIO_EV_DIR_RISING, > IIO_EV_TYPE_THRESH, > 0, 0, 0), No. Now the IIO_EV_DIR_RISING, and later columns are not aligned correctly. Just ignore the checkpatch warning. It's fine as-is. > @@ -987,6 +985,6 @@ static struct spi_driver ad7280_driver = { > }; > module_spi_driver(ad7280_driver); > > -MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>"); > +MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>"); This change needs to come from Michael. Just leave the code as-is. regards, dan carpenter
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 58420dcb406d..52e12d1201b3 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -706,8 +706,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) st->cell_threshhigh) iio_push_event(indio_dev, IIO_EVENT_CODE(IIO_VOLTAGE, - 1, - 0, + 1, + 0, IIO_EV_DIR_RISING, IIO_EV_TYPE_THRESH, 0, 0, 0), @@ -716,8 +716,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) st->cell_threshlow) iio_push_event(indio_dev, IIO_EVENT_CODE(IIO_VOLTAGE, - 1, - 0, + 1, + 0, IIO_EV_DIR_FALLING, IIO_EV_TYPE_THRESH, 0, 0, 0), @@ -725,18 +725,16 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) } else { if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh) iio_push_event(indio_dev, - IIO_UNMOD_EVENT_CODE( - IIO_TEMP, - 0, + IIO_UNMOD_EVENT_CODE(IIO_TEMP, + 0, IIO_EV_TYPE_THRESH, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); else if (((channels[i] >> 11) & 0xFFF) <= st->aux_threshlow) iio_push_event(indio_dev, - IIO_UNMOD_EVENT_CODE( - IIO_TEMP, - 0, + IIO_UNMOD_EVENT_CODE(IIO_TEMP, + 0, IIO_EV_TYPE_THRESH, IIO_EV_DIR_FALLING), iio_get_time_ns(indio_dev)); @@ -987,6 +985,6 @@ static struct spi_driver ad7280_driver = { }; module_spi_driver(ad7280_driver); -MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>"); +MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>"); MODULE_DESCRIPTION("Analog Devices AD7280A"); MODULE_LICENSE("GPL v2");
staging:iio:adc: fix codestyle Signed-off-by: Sergey Efimochkin <efimochkin.sv@phystech.edu> --- drivers/staging/iio/adc/ad7280a.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-)