| Message ID | 489c2bed-b02b-c957-6c16-1dac5e57007d@ndrille.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with, ALC294 | expand |
On Mon, 17 Dec 2018 22:58:04 +0100, Wandrille RONCE wrote: > > From c87ce2119f010db78933c424b8ba6738c3056dff Mon Sep 17 00:00:00 2001 > From: Wandrille RONCE <w@ndrille.fr> > Date: Mon, 17 Dec 2018 19:00:00 +0100 > Subject: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with > ALC294 The empty log is always bad. Could you describe what does your patch do, especially what problem does it fix? Last but not least, please give your sign-off. Otherwise we can't merge the patch. thanks, Takashi > > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 15021c839372..90f30e769a42 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6584,6 +6584,7 @@ static const struct snd_pci_quirk > alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", > ALC269VB_FIXUP_ASUS_ZENBOOK), > SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK), > + SND_PCI_QUIRK(0x1043, 0x10a1, "ASUS UX391UA", ALC294_FIXUP_ASUS_SPK), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", > ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), > -- > 2.19.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
By default, there is no sound on Asus UX391UA on Linux. This patch adds sound support on Asus UX391UA. Tested working by three different users. The problem has also been described at https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1784485 Thanks From 43336539c91759e6f0841bcae79377824b3571e8 Mon Sep 17 00:00:00 2001 From: Wandrille RONCE <w@ndrille.fr> Date: Mon, 17 Dec 2018 19:00:00 +0100 Subject: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with ALC294 Signed-off-by: Wandrille RONCE <w@ndrille.fr> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 15021c839372..90f30e769a42 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6584,6 +6584,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK), + SND_PCI_QUIRK(0x1043, 0x10a1, "ASUS UX391UA", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
On Wed, 19 Dec 2018 03:00:31 +0100, Wandrille RONCE wrote: > > By default, there is no sound on Asus UX391UA on Linux. > > This patch adds sound support on Asus UX391UA. Tested working by three > different users. > > The problem has also been described at > https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1784485 > > Thanks > > > From 43336539c91759e6f0841bcae79377824b3571e8 Mon Sep 17 00:00:00 2001 > From: Wandrille RONCE <w@ndrille.fr> > Date: Mon, 17 Dec 2018 19:00:00 +0100 > Subject: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with > ALC294 > > Signed-off-by: Wandrille RONCE <w@ndrille.fr> Thanks for the patch. The description should have been put in the patch description, but it's OK at this time, I manually applied it. At the next time, please prepare the patch that is directly applicable via git-am. Also, I put the entry in the right position (where the list is sorted in the num id order). thanks, Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 15021c839372..90f30e769a42 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6584,6 +6584,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK), + SND_PCI_QUIRK(0x1043, 0x10a1, "ASUS UX391UA", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A",
From c87ce2119f010db78933c424b8ba6738c3056dff Mon Sep 17 00:00:00 2001 From: Wandrille RONCE <w@ndrille.fr> Date: Mon, 17 Dec 2018 19:00:00 +0100 Subject: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with ALC294 --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),