| Message ID | 20181219073306.54780-1-luc.vanoostenryck@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | remove unneeded declarations in "compat.h" | expand |
On 19/12/2018 07:33, Luc Van Oostenryck wrote: > struct stream & struct stat are defined in this file > but were only used for identical_files() which has been > removed years ago. > > So, remove these declarations. LGTM. BTW I have been testing the 'master' branch (currently up to version: v0.6.0-rc1-22-g2369d10), without finding any errors or regressions. I have now upgraded to Linux Mint 19.1 (64-bit) and fedora 29 (with newer compiler, gcc v2.8.1). Have a good holiday. ATB, Ramsay Jones > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > --- > compat.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/compat.h b/compat.h > index 9814ae3e8..4bba47ad2 100644 > --- a/compat.h > +++ b/compat.h > @@ -10,8 +10,6 @@ > * - "string to long double" (C99 strtold()) > * Missing in Solaris and MinGW > */ > -struct stream; > -struct stat; > > /* > * Our "blob" allocator works on chunks that are multiples >
On 24/12/2018 17:07, Ramsay Jones wrote: > > > On 19/12/2018 07:33, Luc Van Oostenryck wrote: >> struct stream & struct stat are defined in this file >> but were only used for identical_files() which has been >> removed years ago. >> >> So, remove these declarations. > > LGTM. BTW I have been testing the 'master' branch (currently up to > version: v0.6.0-rc1-22-g2369d10), without finding any errors or > regressions. I have now upgraded to Linux Mint 19.1 (64-bit) and > fedora 29 (with newer compiler, gcc v2.8.1). Heh, that should be v8.2.1, of course! :-D > Have a good holiday. ATB, Ramsay Jones
On Mon, Dec 24, 2018 at 08:56:38PM +0000, Ramsay Jones wrote: > > > On 24/12/2018 17:07, Ramsay Jones wrote: > > > > > > On 19/12/2018 07:33, Luc Van Oostenryck wrote: > >> struct stream & struct stat are defined in this file > >> but were only used for identical_files() which has been > >> removed years ago. > >> > >> So, remove these declarations. > > > > LGTM. BTW I have been testing the 'master' branch (currently up to > > version: v0.6.0-rc1-22-g2369d10), without finding any errors or > > regressions. I have now upgraded to Linux Mint 19.1 (64-bit) and > > fedora 29 (with newer compiler, gcc v2.8.1). Great. Thank you. > Heh, that should be v8.2.1, of course! :-D Hehe, gcc 2.8.1, that was quite some years ago! I didn't spotted it here, I autocorrect too much. > > Have a good holiday. Thank you very much. Best Wishes. -- Luc
diff --git a/compat.h b/compat.h index 9814ae3e8..4bba47ad2 100644 --- a/compat.h +++ b/compat.h @@ -10,8 +10,6 @@ * - "string to long double" (C99 strtold()) * Missing in Solaris and MinGW */ -struct stream; -struct stat; /* * Our "blob" allocator works on chunks that are multiples
struct stream & struct stat are defined in this file but were only used for identical_files() which has been removed years ago. So, remove these declarations. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> --- compat.h | 2 -- 1 file changed, 2 deletions(-)