[GIT,PULL] Please pull NFS client bugfixes
mbox series

Message ID 1d49def46ad91048c59da7b1f76f135ee1aa1060.camel@hammerspace.com
State New
Headers show
Series
  • [GIT,PULL] Please pull NFS client bugfixes
Related show

Pull-request

git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-6

Message

Trond Myklebust Dec. 19, 2018, 4:49 p.m. UTC
Hi Linus,

The following 3 patches fix a regression in the NFS/RPC TPC re-
connection code which can cause the RPC transmission to hang. The issue
was discovered by Dave Wysochanski last week.

With this pull, we still have one more regression to fix. MIPS is
seeing data corruption due to the fact that the iovec_iter code does
not appear to call flush_dcache_page() after copying data into the bvec
pages. We need guidance from Al as to how he wants this fixed.

Cheers
  Trond

The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd:

  Linux 4.20-rc7 (2018-12-16 15:46:55 -0800)

are available in the Git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-6

for you to fetch changes up to abc13275771fac77e2d7b129c289522dacb644b6:

  SUNRPC: Remove xprt_connect_status() (2018-12-18 11:04:10 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 4.20

Bugfixes:
- Fix TCP socket disconnection races by ensuring we always call
  xprt_disconnect_done() after releasing the socket.
- Fix a race when clearing both XPRT_CONNECTING and XPRT_LOCKED
- Remove xprt_connect_status() so it does not mask errors that should
  be handled by call_connect_status()

----------------------------------------------------------------
Trond Myklebust (3):
      SUNRPC: Fix disconnection races
      SUNRPC: Fix a race with XPRT_CONNECTING
      SUNRPC: Remove xprt_connect_status()

 net/sunrpc/clnt.c     |  1 +
 net/sunrpc/xprt.c     | 35 ++++-------------------------------
 net/sunrpc/xprtsock.c | 10 ++++------
 3 files changed, 9 insertions(+), 37 deletions(-)

Comments

pr-tracker-bot@kernel.org Dec. 20, 2018, 2:50 a.m. UTC | #1
The pull request you sent on Wed, 19 Dec 2018 16:49:11 +0000:

> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-6

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8c9dff1ebd721a3b19a002d1a901d4dc31b18ebb

Thank you!
Geert Uytterhoeven Dec. 20, 2018, 3:23 p.m. UTC | #2
On Wed, Dec 19, 2018 at 9:28 PM Trond Myklebust <trondmy@hammerspace.com> wrote:
> The following 3 patches fix a regression in the NFS/RPC TPC re-
> connection code which can cause the RPC transmission to hang. The issue
> was discovered by Dave Wysochanski last week.
>
> With this pull, we still have one more regression to fix. MIPS is
> seeing data corruption due to the fact that the iovec_iter code does
> not appear to call flush_dcache_page() after copying data into the bvec
> pages. We need guidance from Al as to how he wants this fixed.

FTR, the report for that issue is
https://lore.kernel.org/lkml/CAMuHMdVJr0PwvJg3FeTCy7vxuyY1=S1tPLHO7hPsoZX4wZ+-cQ@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert